AudioIO: add spectrogram samples for C++/python by SinM9 · Pull Request #20934 · opencv/opencv

SinM9 · 2021-10-24T18:45:48Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

author Sinitsina Maria <marusya19.09.99@gmail.com> 1635100993 +0300 committer Sinitsina Maria <marusya19.09.99@gmail.com> 1636985460 +0300 inital update samples fix warnings

SinM9 · 2021-11-15T14:30:48Z

@allnes Check please

alalek · 2021-11-15T11:39:50Z

samples/cpp/spectrogram.cpp

+    {
+        line(img, Point(i-1, static_cast<int>(reshape_audio[i-1])), Point(i, static_cast<int>(reshape_audio[i])), color, thickness);
+    }
+    resize(img, img, Size(cols, rows), INTER_AREA );


avoid "inplace" operations. There is performance src copy penalty.

alalek · 2021-11-15T11:41:34Z

samples/cpp/spectrogram.cpp

+        "{inputType i    | file          | file or microphone                       }"
+        "{draw d         | static        | type of drawing: \n\t\t\tstatic - for plotting graph(s) across the entire input audio \n\t\t\tdynamic - for plotting graph(s) in a time-updating window}"
+        "{graph g        | ampl_and_spec | type of graph: amplitude graph or/and spectrogram. Please use tags below : \n\t\t\tampl - draw the amplitude graph \n\t\t\tspec - draw the spectrogram\n\t\t\tampl_and_spec - draw the amplitude graph and spectrogram on one image under each other}"
+        "{audio a        |../../../samples/data/Megamind.avi| name and path to file                    }"


Use cv.samples.findFile (Python) / samples::findFile (C++) instead of ../

alalek · 2021-11-15T11:43:23Z

samples/python/spectrogram.py

+              cv.CAP_PROP_AUDIO_DATA_DEPTH, cv.CV_16S]
+    params = np.asarray(params)
+
+    cap.open(file, cv.CAP_MSMF, params)


cv.CAP_MSMF

This should be removed. We want to support other backends too.

Use CAP_ANY.

alalek · 2021-11-15T11:44:37Z

samples/python/spectrogram.py

+    parser.add_argument("-g", "--graph", dest="graph", type=str, default="ampl_and_spec",
+                        help="type of graph: amplitude graph or/and spectrogram. Please use tags below : ampl - draw the amplitude graph; spec - draw the spectrogram; ampl_and_spec - draw the amplitude graph and spectrogram on one image under each other")
+
+    parser.add_argument("-a", "--audio", dest="audio", type=str, default='../data/Megamind.avi',


../

need to be removed

alalek · 2021-11-15T11:45:48Z

samples/python/spectrogram.py

@@ -0,0 +1,827 @@
+import cv2 as cv
+import numpy as np


Due to compatibility reasons numpy should go first (as a dependency)

alalek · 2021-11-17T19:53:31Z

samples/cpp/spectrogram.cpp

+    }
+    else if (windowType == "Hamming")
+    {
+        double pi = 2 * acos(-1.0);


CV_PI, M_PI.

alalek · 2021-11-17T19:54:01Z

samples/cpp/spectrogram.cpp

+        double pi = 2 * acos(-1.0);
+        for (int j = 1 - windLen; j < windLen; j+=2)
+        {
+            WindType.push_back(j * (0.53836 - 0.46164 * (cos(pi * j / (windLen - 1)))));


Please add link at Wiki article or other documents so reviewers can validate used expressions

alalek · 2021-11-17T19:58:31Z

samples/cpp/spectrogram.cpp

+    string grid = parser.get<string>("grid");
+    if ((grid != "on") && (grid != "off"))


get<bool>()

alalek · 2021-11-17T20:00:02Z

samples/cpp/spectrogram.cpp

+
+}
+
+static bool checkArgs(CommandLineParser parser)


Input parameters should be passed as 'const reference'

alalek · 2021-11-17T20:03:59Z

samples/cpp/spectrogram.cpp

+        if (cap.grab())
+        {
+            for (int nCh = 0; nCh < numberOfChannels; nCh++)
+            {


There is one imshow for multiple channels.

berak · 2021-11-20T11:20:25Z

samples/cpp/spectrogram.cpp

+    cap.open(0, CAP_MSMF, params);
+    if (!cap.isOpened())
+    {
+        cerr << "ERROR! Can't to open microphone" << endl;


better:

cerr << "ERROR! Can't open microphone" << endl;

(w/o the "to")

alalek · 2021-11-18T03:57:09Z

samples/cpp/spectrogram.cpp

@@ -0,0 +1,1124 @@
+#include <opencv2/core.hpp>


Please rename samples: add audio_ prefix

alalek

Well done! Thank you 👍

AudioIO: add spectrogram samples for C++/python

SinM9 force-pushed the spectrogram_samples branch from 50cf0fc to fce3b22 Compare November 15, 2021 11:14

SinM9 marked this pull request as ready for review November 15, 2021 11:45

parent 394e640

0cf61d2

author Sinitsina Maria <marusya19.09.99@gmail.com> 1635100993 +0300 committer Sinitsina Maria <marusya19.09.99@gmail.com> 1636985460 +0300 inital update samples fix warnings

SinM9 force-pushed the spectrogram_samples branch from fce3b22 to 0cf61d2 Compare November 15, 2021 14:19

SinM9 changed the title ~~Spectrogram samples~~ AudioIO: add spectrogram samples for C++/python Nov 15, 2021

alalek reviewed Nov 17, 2021

View reviewed changes

berak reviewed Nov 20, 2021

View reviewed changes

SinM9 and others added 2 commits November 28, 2021 11:55

Merge branch 'opencv:4.x' into spectrogram_samples

30a5427

fixes

6b23c8e

SinM9 force-pushed the spectrogram_samples branch from a878ba1 to 6b23c8e Compare November 28, 2021 18:03

alalek reviewed Dec 14, 2021

View reviewed changes

SinM9 and others added 2 commits December 14, 2021 19:14

Merge branch 'opencv:4.x' into spectrogram_samples

c3bd33f

rename samples

f2f5273

alalek approved these changes Dec 14, 2021

View reviewed changes

alalek merged commit d8b1fc4 into opencv:4.x Dec 14, 2021

alalek mentioned this pull request Dec 30, 2021

(5.x) Merge 4.x #21371

Merged

alalek mentioned this pull request Feb 22, 2022

(5.x) Merge 4.x #21651

Merged

a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023

Merge pull request opencv#20934 from SinM9:spectrogram_samples

6c3cd0c

AudioIO: add spectrogram samples for C++/python

		string grid = parser.get<string>("grid");
		if ((grid != "on") && (grid != "off"))

Uh oh!

Conversation

SinM9 commented Oct 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

SinM9 commented Nov 15, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SinM9 commented Oct 24, 2021 •

edited

Loading