Skip to content

Move API sample code to tutorial_code location#20857

Merged
alalek merged 2 commits intoopencv:4.xfrom
alexgiving:atrutnev/move_API_samples
Nov 12, 2021
Merged

Move API sample code to tutorial_code location#20857
alalek merged 2 commits intoopencv:4.xfrom
alexgiving:atrutnev/move_API_samples

Conversation

@alexgiving
Copy link
Copy Markdown
Member

@alexgiving alexgiving commented Oct 11, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.4.1

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 11, 2021

@dmatveev Do we really need to do that?

AFAIK, G-API documentation is stored under gapi module: https://github.com/opencv/opencv/tree/master/modules/gapi/doc

@alexgiving alexgiving force-pushed the atrutnev/move_API_samples branch from 1e1a47f to a79dad1 Compare October 13, 2021 13:11
@alexgiving alexgiving force-pushed the atrutnev/move_API_samples branch 2 times, most recently from 7210750 to 987b248 Compare November 1, 2021 09:46
@alexgiving alexgiving requested a review from dmatveev November 1, 2021 11:32
@alexgiving alexgiving force-pushed the atrutnev/move_API_samples branch from 43ab6fc to 0f2404b Compare November 3, 2021 10:57
@alexgiving alexgiving requested a review from OrestChura November 9, 2021 09:48
OrestChura
OrestChura approved these changes Nov 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@OrestChura OrestChura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexgiving
Copy link
Copy Markdown
Member Author

alexgiving commented Nov 11, 2021

@alalek could you merge it please

@dmatveev dmatveev self-assigned this Nov 11, 2021
dmatveev
dmatveev reviewed Nov 11, 2021
View reviewed changes
modules/gapi/doc/20-kernel-api.markdown Outdated
G_TYPED_KERNEL():

@snippet modules/gapi/samples/kernel_api_snippets.cpp filter2d_api
@snippet samples/cpp/tutorial_code/gapi/kernel_api_snippets/kernel_api_snippets.cpp filter2d_api
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kernel_api_snippets

I don't think we need an individual directory for every of the snippet files. You can place them all in just doc_snippets directory and make it once. The tutorial_code/gapi directory now may look overloaded with details.

Copy link
Copy Markdown
Member Author

@alexgiving alexgiving Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will move all snippets files to tutorial_code/gapi/doc_snippets

@alexgiving alexgiving force-pushed the atrutnev/move_API_samples branch from b3f75a8 to 49a38cc Compare November 11, 2021 14:33
dmatveev
dmatveev approved these changes Nov 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , thanks!

@alexgiving
Copy link
Copy Markdown
Member Author

alexgiving commented Nov 12, 2021

@alalek please merge the PR

@alalek alalek merged commit b525480 into opencv:4.x Nov 12, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
@dmatveev dmatveev mentioned this pull request Aug 25, 2022
Closed
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#20857 from alexgiving:atrutnev/move_API_sam…
8701f19 
…ples

Move API sample code to tutorial_code location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@OrestChura OrestChura OrestChura approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

4 participants

@alexgiving @alalek @dmatveev @OrestChura