Skip to content

G-API: Extend ie::Params to specify batch size#20856

Merged
alalek merged 2 commits intoopencv:masterfrom
TolyaTalamanov:at/cfg-batch-size
Oct 18, 2021
Merged

G-API: Extend ie::Params to specify batch size#20856
alalek merged 2 commits intoopencv:masterfrom
TolyaTalamanov:at/cfg-batch-size

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Oct 11, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

mpashchenkov
mpashchenkov approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like correct pulling of IE net-function to cfg-function.

modules/gapi/include/opencv2/gapi/infer/ie.hpp
return *this;
}

Params<Net>& cfgBatchSize(const size_t size) {
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add description of the function? This will avoid this step in the future.

Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 doxygen is required

Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@dmatveev dmatveev self-assigned this Oct 14, 2021
@dmatveev dmatveev added this to the 4.5.5 milestone Oct 14, 2021
dmatveev
dmatveev reviewed Oct 14, 2021
View reviewed changes
modules/gapi/include/opencv2/gapi/infer/ie.hpp
return *this;
}

Params<Net>& cfgBatchSize(const size_t size) {
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 doxygen is required

TolyaTalamanov
TolyaTalamanov commented Oct 15, 2021
View reviewed changes
modules/gapi/include/opencv2/gapi/infer/ie.hpp
/** @brief Specifies the inference batch size.

The function is used to specify inference batch size.
Follow https://docs.openvinotoolkit.org/latest/classInferenceEngine_1_1CNNNetwork.html#a8e9d19270a48aab50cb5b1c43eecb8e9 for additional information
Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalek Is it possible to wrap this to the next line? How to do that properly?

Copy link
Copy Markdown
Member

@alalek alalek Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, Doxygen merges text from consequence lines into one paragraph.
But don't divide the link itself.

Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 18, 2021

Docs:

dmatveev
dmatveev approved these changes Oct 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 18, 2021

@alalek Could you merge it, please?

@alalek alalek merged commit b5a9a67 into opencv:master Oct 18, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov
Merge pull request opencv#20856 from TolyaTalamanov:at/cfg-batch-size
7a51f17 
G-API: Extend ie::Params to specify batch size

* Add cfgBatchSize to ie::Params

* Fix comments to review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@dmatveev dmatveev dmatveev approved these changes

@mpashchenkov mpashchenkov mpashchenkov approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

4 participants

@TolyaTalamanov @dmatveev @alalek @mpashchenkov