Skip to content

G-API: oneVPL (simplification) Add simple decode pipeline#20739

Merged
alalek merged 3 commits intoopencv:masterfrom
sivanov-work:merge_base_decode
Sep 28, 2021
Merged

G-API: oneVPL (simplification) Add simple decode pipeline#20739
alalek merged 3 commits intoopencv:masterfrom
sivanov-work:merge_base_decode

Conversation

@sivanov-work
Copy link
Copy Markdown
Contributor

@sivanov-work sivanov-work commented Sep 23, 2021 •
edited
Loading

this PR is the single one in series of #20469
Introduces simple decoding pipeline & related data structures

P.S. This pipeline flow would be improved for fully async-decode flow in the next PRs

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dmatveev
dmatveev reviewed Sep 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but..

modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
break;
case MFX_FOURCC_I010:
case MFX_FOURCC_P010:
nbytes = width * height + 2 * half_width * half_height;
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this size in bytes include alignment?

In some platforms, image data (stride) is aligned to some multiplier and may exceed its logical size.

Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, without alignment.
could you please share some resources or provide some info how to deal with it?

Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, unfortunately. usually we learn about this limitations when enabling this or that particular platform. even more, on kmb one revision had one alignment and other revision has required the other.

At least I'd make it configurable somehow

sivanov-work
sivanov-work commented Sep 24, 2021
View reviewed changes
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
break;
case MFX_FOURCC_I010:
case MFX_FOURCC_P010:
nbytes = width * height + 2 * half_width * half_height;
Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, without alignment.
could you please share some resources or provide some info how to deal with it?

modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp Outdated
", offset: " << out_buf_ptr_offset <<
", W: " << surfW <<
", H: " << surfH);
GAPI_Assert(false && "Invalid offset");
Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will throw exception too

dmatveev
dmatveev approved these changes Sep 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge

@alalek alalek merged commit c1148c4 into opencv:master Sep 28, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
@sivanov-work sivanov-work deleted the merge_base_decode branch March 5, 2022 05:49
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@sivanov-work
Merge pull request opencv#20739 from sivanov-work:merge_base_decode
c654402 
G-API: oneVPL (simplification) Add simple decode pipeline

* Add simple decode pipeline & add onevpl namespace

* Address some review comments

* Add compilation guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@rgarnov rgarnov Awaiting requested review from rgarnov

@AsyaPronina AsyaPronina Awaiting requested review from AsyaPronina

@smirnov-alexey smirnov-alexey Awaiting requested review from smirnov-alexey

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi feature

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@sivanov-work @dmatveev @alalek