Skip to content

generate radon checkerboard#20735

Merged
alalek merged 5 commits intoopencv:masterfrom
AleksandrPanov:radon_checkerboard
Sep 28, 2021
Merged

generate radon checkerboard#20735
alalek merged 5 commits intoopencv:masterfrom
AleksandrPanov:radon_checkerboard

Conversation

@AleksandrPanov
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov commented Sep 22, 2021 •
edited
Loading

Generate radon checkerboard for findChessboardCornersSB and update docs
resolves #20364

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 23, 2021

@AleksandrPanov Is this PR in draft status?

@AleksandrPanov
Copy link
Copy Markdown
Contributor Author

AleksandrPanov commented Sep 23, 2021

Yes

@AleksandrPanov
Copy link
Copy Markdown
Contributor Author

AleksandrPanov commented Sep 23, 2021

The current code works like this:

Current radon pattern view

-o out.svg -r 8 -c 9 -T radon_checkerboard -s 20.0 -u mm -m 0 0 0 1 2 0 4 4 4 5 8 7 8 0

image
image

I'm also going to update the documentation.

@AleksandrPanov AleksandrPanov added the category: documentation Documentation fix or update label Sep 23, 2021
@AleksandrPanov AleksandrPanov marked this pull request as ready for review September 24, 2021 16:24
@AleksandrPanov
Copy link
Copy Markdown
Contributor Author

AleksandrPanov commented Sep 24, 2021

@mshabunin, @alalek pool request is ready for review

mshabunin
mshabunin approved these changes Sep 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + minor comments

@alalek alalek merged commit 982745f into opencv:master Sep 28, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
@alalek alalek mentioned this pull request Nov 9, 2021
Closed
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#20735 from AleksandrPanov:radon_checkerboard
413e9fb 
generate radon checkerboard

* added _make_round_rect

* added round rect to make_checkerboard_pattern

* added markers

* update docs

* removed links to findChessboardCornersSB() and added checks to markers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

category: calib3d category: documentation Documentation fix or update feature

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

please add to gen_pattern.py the option to create radon checkerboard

3 participants

@AleksandrPanov @alalek @mshabunin