Skip to content

G-API: Handle reshape for generic case in GExecutor#20705

Merged
alalek merged 4 commits intoopencv:masterfrom
TolyaTalamanov:at/handle-reshape-in-gexecutor
Sep 23, 2021
Merged

G-API: Handle reshape for generic case in GExecutor#20705
alalek merged 4 commits intoopencv:masterfrom
TolyaTalamanov:at/handle-reshape-in-gexecutor

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Sep 15, 2021 •
edited by alalek
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 15, 2021

@rgarnov @dmatveev Could you have a look, please ?

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 15, 2021

Is it handled properly for GStreamingExecutor ?
https://github.com/opencv/opencv/blob/master/modules/gapi/src/executor/gstreamingexecutor.cpp#L1425-L1449

@dmatveev dmatveev added this to the 4.5.4 milestone Sep 15, 2021
@dmatveev dmatveev self-assigned this Sep 15, 2021
@dmatveev dmatveev self-requested a review September 15, 2021 18:27
dmatveev
dmatveev reviewed Sep 15, 2021
View reviewed changes
dmatveev
dmatveev reviewed Sep 21, 2021
View reviewed changes
dmatveev
dmatveev approved these changes Sep 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , thanks!

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 23, 2021

@alalek Can it be merged ?

@alalek alalek merged commit 499d8ad into opencv:master Sep 23, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov
Merge pull request opencv#20705 from TolyaTalamanov:at/handle-reshape…
03c51dd 
…-in-gexecutor

G-API: Handle reshape for generic case in GExecutor

* Handle reshape for generic case for GExecutor

* Add initResources

* Add tests

* Refactor reshape method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@rgarnov rgarnov rgarnov approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@TolyaTalamanov @dmatveev @rgarnov @alalek