Add ExpandDims layer of tf_importer.cpp#20702
Merged
alalek merged 8 commits intoopencv:masterfrom Oct 4, 2021
Merged
Conversation
Member
Author
|
jenkins cn please retry a build |
1 similar comment
Member
|
jenkins cn please retry a build |
rogday
suggested changes
Sep 24, 2021
Member
There was a problem hiding this comment.
Thank you for contribution! Can you clarify, under which conditions this implementation of ExpandDims will work? My understanding is that the network should specify shapes and they shouldn't be dynamic, is that correct? Also, could you rebase extra, so that it can be tested on CI?
zihaomu
commented
Sep 27, 2021
rogday
suggested changes
Sep 28, 2021
Member
rogday
left a comment
There was a problem hiding this comment.
Looks good with a few comments. 👍
rogday
approved these changes
Sep 29, 2021
Member
rogday
left a comment
There was a problem hiding this comment.
Please, add a space between ifs and fors and opening parentheses. Otherwise looks good, thank you! 👍
4 tasks
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
Add ExpandDims layer of tf_importer.cpp * Add ExpandDims to tf_importer. * add -1 expand test case. * Support different dimensions of input. * Compatible with 5-dimensional NDHWC data * Code align * support 3-dim input. * 3-dim bug fixed. * fixing error of code format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ExpandDimslayer was implemented by "Reshape layer."The following code will generate the
ExpandDimslayer:Related test data could be found at PR in opencv_extra.
There are still some unresolved issues here:
Currently, this code can only handle when the dimension input layer dimension is 4., since the different Datalayout between OpenCV and Tensorflow.(Solved.)dstNet.getLayerShapes()function. This implementation can not handle this model.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.