G-API: oneVPL (simplification) Add data adapter & Cfg params by sivanov-work · Pull Request #20570 · opencv/opencv

sivanov-work · 2021-08-18T06:29:02Z

this PR is the single one in series of #20469

Introduce DataProvider adapter: to read data as either FILE or stream or custom
Introduce CFG params

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dmatveev · 2021-08-18T22:26:59Z

Simple question - is a machine in OpenCV buildbot with vpl available so that this code can actually be built? cc: @alalek

Harder question - I doubt if file source and configs are the right thing for this step - the source itself doesn't work isn't it?

sivanov-work · 2021-08-20T06:35:33Z

@dmatveev

Simple question - is a machine in OpenCV buildbot with vpl available so that this code can actually be built? cc: @alalek

Harder question - I doubt if file source and configs are the right thing for this step - the source itself doesn't work isn't it?

I found a comment from @alalek about possibility for introducing oneAPI in next 2-3 weeks
#20546 (review)

Looks like it' might be answer and looks like my further PRs code would be inactivated until this time

@alalek could you confirm or reject please?

modules/gapi/include/opencv2/gapi/streaming/onevpl/onevpl_cfg_params.hpp

dmatveev · 2021-08-20T14:10:05Z

modules/gapi/include/opencv2/gapi/streaming/onevpl/onevpl_cfg_params.hpp

+                                      void*,
+                                      std::string>;
+    template<typename ValueType>
+    static oneVPL_cfg_param create(const std::string& name, ValueType&& value, bool is_major = true) {


what does is_major mean? Also, I'd suggest writing doxygen comments at some early point since we always forget to add em later

will be added

modules/gapi/include/opencv2/gapi/streaming/onevpl/onevpl_cfg_params.hpp

dmatveev · 2021-08-20T14:12:51Z

modules/gapi/include/opencv2/gapi/streaming/onevpl/onevpl_data_provider_interface.hpp

+struct GAPI_EXPORTS DataProviderException : public std::exception {
+    virtual ~DataProviderException() {};
+};
+
+struct GAPI_EXPORTS DataProviderSystemErrorException : public DataProviderException {
+    DataProviderSystemErrorException(int error_code, const std::string& desription = std::string());
+    virtual ~DataProviderSystemErrorException();
+    virtual const char* what() const noexcept override;
+
+private:
+    std::string reason;
+};


y u need a special exception type here? usually we throw a logic_error and its string argument is enough to provide reason like here.

in recognition reason: i believe user can recognize that and make a proper decision on explicit error.

BTW it depict explicit intention during DataProvider implementation .When i saw an abstract interface i would ask myself: how i should process an unrecoverable error here: logic_error or runtime_error or bad_alloc of filesystem error? Answer is DataProviderSystemErrorException

We don't have a project-wide exception / error-handling policy here (except the one I mentioned above), so I'm just wondering whether it is the right time to introduce / derive a new one or keep the old approach (before the one is introduced)

modules/gapi/include/opencv2/gapi/streaming/onevpl/onevpl_data_provider_interface.hpp

modules/gapi/samples/onevpl_infer_single_roi.cpp

modules/gapi/src/streaming/onevpl/onevpl_cfg_params.cpp

dmatveev

LGTM

sivanov-work · 2021-08-24T12:18:30Z

@alalek Could you please merge it?
Custom Win is failed on PR build table (https://pullrequest.opencv.org/buildbot/builders/precommit_custom_windows/builds/2550) but i'm sure this is not my fault: some dnn python tests were failed in that build and i didn't touch anything in python or dnn

…pter G-API: oneVPL (simplification) Add data adapter & Cfg params * Add cfg_param & data_provider * Fix compilation after rebase * Apply some comments * Apply default ctor outside class definition comment * Apply cfg param in source * Fix compilation: add virtual dtor * Move cfg_params in regular gapi src list * Fix compilation: add export.hpp * Add errno.h * Add errno.h * Apply namespace comment * Add several Doxygen & rename cfg_param * Fix build * Update Doxygen docs for onevpl * Fix typo

sivanov-work added 5 commits August 18, 2021 09:17

Add cfg_param & data_provider

7c032f6

Fix compilation after rebase

c544043

Apply some comments

707dbbc

Apply default ctor outside class definition comment

90ea2e3

Apply cfg param in source

aed3573

sivanov-work added the category: g-api / gapi label Aug 18, 2021

sivanov-work requested review from AsyaPronina, TolyaTalamanov, dmatveev, mpashchenkov, rgarnov and smirnov-alexey August 18, 2021 06:30

sivanov-work added 5 commits August 18, 2021 09:44

Fix compilation: add virtual dtor

200c414

Move cfg_params in regular gapi src list

1c8ede4

Fix compilation: add export.hpp

586d6fc

Add errno.h

6d6b37b

Add errno.h

c4eb439

dmatveev self-assigned this Aug 18, 2021

dmatveev added this to the 4.5.4 milestone Aug 18, 2021

dmatveev reviewed Aug 20, 2021

View reviewed changes

sivanov-work added 2 commits August 23, 2021 12:27

Apply namespace comment

c3e0396

Add several Doxygen & rename cfg_param

06acab7

dmatveev approved these changes Aug 23, 2021

View reviewed changes

sivanov-work added 3 commits August 24, 2021 09:04

Fix build

65087f8

Update Doxygen docs for onevpl

ca2b9b0

Fix typo

44e1216

alalek merged commit 65ef82a into opencv:master Aug 24, 2021

alalek mentioned this pull request Oct 15, 2021

(5.x) Merge 4.x #20886

Merged

Uh oh!

Conversation

sivanov-work commented Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Build configuration

Uh oh!

dmatveev commented Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sivanov-work commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dmatveev Aug 20, 2021

Choose a reason for hiding this comment

Uh oh!

sivanov-work Aug 23, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dmatveev Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sivanov-work Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmatveev Aug 23, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

sivanov-work commented Aug 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sivanov-work commented Aug 18, 2021 •

edited

Loading

dmatveev commented Aug 18, 2021 •

edited

Loading

sivanov-work commented Aug 20, 2021 •

edited

Loading

dmatveev Aug 20, 2021 •

edited

Loading

sivanov-work Aug 23, 2021 •

edited

Loading