[G-API] Prohibit setPrecision & preprocessing for importedNetworks#20528
Merged
alalek merged 4 commits intoopencv:masterfrom Aug 18, 2021
Merged
Conversation
94b023e to
dd49b8d
Compare
Contributor
Author
|
@mpashchenkov Could you have a look ? |
mpashchenkov
approved these changes
Aug 13, 2021
Contributor
mpashchenkov
left a comment
There was a problem hiding this comment.
Good for me. Thanks.
dmatveev
approved these changes
Aug 13, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
LGTM (didn't check every line though), will our vpu camera cases continue working after these changes (where the blobs are imported and have to consume NV12 so the preprocessing is enabled in that case)?
| uu.params.layer_names_to_reshape.end()) { | ||
| configureInputReshapeByImage(ii, mm, input_reshape_table); | ||
| // NB: Configuring input precision and network reshape must be done | ||
| // only for loadNetwork way. |
Contributor
There was a problem hiding this comment.
only in the LoadNetwork case is maybe a better wording
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…blob-precision-bug [G-API] Prohibit setPrecision & preprocessing for importedNetworks * Prohibit preprocessing for imported networks * Fix typo input_names -> output_names * Move setBlob logic to separate function * Change comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Build configuration