[G-API] Expand PyParams to support constInput#20508
Merged
alalek merged 4 commits intoopencv:masterfrom Aug 6, 2021
Merged
Conversation
mpashchenkov
reviewed
Aug 5, 2021
| const std::string &device); | ||
|
|
||
| PyParams(const std::string &tag, | ||
| GAPI_WRAP PyParams(const std::string &tag, |
Contributor
There was a problem hiding this comment.
Alignment broken, after adding GAPI_WRAP
Member
There was a problem hiding this comment.
It is not done for the ctor above.
It makes sense to put "wrapping" modifiers on new line before standard declaration instead:
GAPI_WRAP
PyParams(...for ctor and other methods / functions.
mpashchenkov
reviewed
Aug 5, 2021
dmatveev
approved these changes
Aug 5, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
LGTM but please consider tests for the backlog
Contributor
Author
Yep, now it seems to me that we don't have such kind of networks on CI |
mpashchenkov
approved these changes
Aug 5, 2021
Contributor
Author
|
@alalek Can it be merged ? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…pyparams [G-API] Expand PyParams to support constInput * Wrap constInputs to python * Wrap cfgNumRequests * Fix alignment * Move macro to the line above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Build configuration