fix ONNXImporter diagnostic mode layer registration issue#20494
Merged
alalek merged 6 commits intoopencv:masterfrom Aug 20, 2021
Merged
fix ONNXImporter diagnostic mode layer registration issue#20494alalek merged 6 commits intoopencv:masterfrom
alalek merged 6 commits intoopencv:masterfrom
Conversation
alalek
reviewed
Aug 4, 2021
| * @brief Skip model import after diagnostic run in readNet() functions. | ||
| * @param[in] skip Indicates whether to skip the import. | ||
| */ | ||
| CV_EXPORTS void skipModelImport(bool skip); |
Member
There was a problem hiding this comment.
Why do we need that as part of public API?
Member
Author
There was a problem hiding this comment.
This function is used in test_tf_importer.cpp and prevents tests of diagnostic mode from failing. I agree that users probably shouldn't care about this. I couldn't move the definition to dnn_common.hpp because of undefined reference error(implementation was placed in dnn.cpp). Can you suggest a better place for it or how to get around this problem?
As for the contents of layer_reg.private.hpp, I think removing it would be a breaking change, and so if someone is using it, they should be able to use it thread-safely.
dc07424 to
901b810
Compare
…f DNN_DIAGNOSTICS_RUN between onnx and tf importers
901b810 to
71c09c2
Compare
60b1d5d to
3960253
Compare
3960253 to
34f7f56
Compare
0ae1190 to
e286cc2
Compare
Contributor
Member
Author
|
I found an error in TF logic. |
alalek
approved these changes
Aug 20, 2021
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
fix ONNXImporter diagnostic mode layer registration issue * fix layer registration, thread unsafe access and align the behavior of DNN_DIAGNOSTICS_RUN between onnx and tf importers * move skipModelInput * print all missing layers * address TF issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In diagnostic mode it showed that some layer isn't supported even if it was registered beforehand.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.