Skip to content

Support cumsum layer for onnx#20483

Merged
alalek merged 3 commits intoopencv:masterfrom
thezane:support-cumsum-layer-for-onnx
Aug 17, 2021
Merged

Support cumsum layer for onnx#20483
alalek merged 3 commits intoopencv:masterfrom
thezane:support-cumsum-layer-for-onnx

Conversation

@thezane
Copy link
Copy Markdown
Contributor

@thezane thezane commented Jul 31, 2021 •
edited
Loading

Support importing ONNX CumSum layer for CPU. This patch addresses #20110.

ONNX CumSum specs:
https://github.com/onnx/onnx/blob/master/docs/Operators.md#CumSum

Test data:
opencv/opencv_extra#890

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@thezane thezane force-pushed the support-cumsum-layer-for-onnx branch from 6387e8e to ea53441 Compare July 31, 2021 16:38
@thezane thezane mentioned this pull request Jul 31, 2021
Merged
@thezane thezane force-pushed the support-cumsum-layer-for-onnx branch 13 times, most recently from f2d7211 to e40958b Compare August 2, 2021 05:04
@thezane thezane marked this pull request as ready for review August 2, 2021 06:56
@asmorkalov asmorkalov requested a review from rogday August 2, 2021 08:09
rogday
rogday reviewed Aug 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

rogday
rogday reviewed Aug 2, 2021
View reviewed changes
@thezane thezane force-pushed the support-cumsum-layer-for-onnx branch from 8fdac37 to 9d3eef6 Compare August 5, 2021 00:37
@rogday
Copy link
Copy Markdown
Member

rogday commented Aug 9, 2021

Can you resolve the conflicts? Otherwise looks good, thank you!

@thezane thezane force-pushed the support-cumsum-layer-for-onnx branch from 9d3eef6 to 04e18ee Compare August 12, 2021 05:41
@thezane
Copy link
Copy Markdown
Contributor Author

thezane commented Aug 12, 2021

Can you resolve the conflicts? Otherwise looks good, thank you!

Resolved.

@thezane thezane force-pushed the support-cumsum-layer-for-onnx branch from 04e18ee to 988d99b Compare August 13, 2021 01:47
@asmorkalov asmorkalov requested a review from rogday August 16, 2021 09:15
rogday
rogday approved these changes Aug 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alalek alalek merged commit 210bfaf into opencv:master Aug 17, 2021
@thezane thezane deleted the support-cumsum-layer-for-onnx branch August 18, 2021 01:34
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@thezane
Merge pull request opencv#20483 from thezane:support-cumsum-layer-for…
f6ec2f6 
…-onnx

* Support cumsum layer for onnx

* Add unit tests

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogday rogday

Labels

category: dnn feature

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@thezane @rogday @alalek