Skip to content

Added exposure and gain props, maximized pixel clk#20475

Merged
alalek merged 2 commits intoopencv:masterfrom
nibeh:patch-1
Aug 24, 2021
Merged

Added exposure and gain props, maximized pixel clk#20475
alalek merged 2 commits intoopencv:masterfrom
nibeh:patch-1

Conversation

@nibeh
Copy link
Copy Markdown
Contributor

@nibeh nibeh commented Jul 29, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Jul 30, 2021

/cc @andy-held

pixel clock maximization is not suitable for all use cases, so I removed it from PR.
@asmorkalov
Copy link
Copy Markdown
Contributor

@andy-held Have you have a chance to look at the patch?

@andy-held
Copy link
Copy Markdown
Contributor

Yeah, I gave it a thumbs-up : )

I would even have said that pixel clock maximization makes sense currently, while there is no direct way to modify it. But I would accept it either way. Very nice that people use this.

@asmorkalov asmorkalov self-requested a review August 23, 2021 11:28
@asmorkalov
Copy link
Copy Markdown
Contributor

@alalek Could you merge the patch?

@alalek alalek merged commit fdaa6ff into opencv:master Aug 24, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
* Added exposure and gain props, maximized pixel clk

* removed pixel clock maximization

pixel clock maximization is not suitable for all use cases, so I removed it from PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants