Skip to content

GAPI: Implement ConstValue serialize/deserialize#20372

Merged
alalek merged 4 commits intoopencv:masterfrom
sivanov-work:serialize
Jul 9, 2021
Merged

GAPI: Implement ConstValue serialize/deserialize#20372
alalek merged 4 commits intoopencv:masterfrom
sivanov-work:serialize

Conversation

@sivanov-work
Copy link
Copy Markdown
Contributor

@sivanov-work sivanov-work commented Jul 7, 2021 •
edited
Loading

Currently GScalar may be value-initialized, in this case its value is bound within the graph as a ConstValue:

struct ConstValue
{
    static const char *name() { return "ConstValue"; }
    GRunArg arg;
};

Put this information into the serialized graph, and test that it deserialize properly (as part of a real graph).

 
The following use cases must be implemented

auto p = cv::gapi::serialize(cv::GComputation(GIn(a), GOut(cv::gapi::addC(a,10))));
...
auto p = cv::gapi::serialize(cv::GComputation(GIn(a), GOut(a+10)))
...
auto p = cv::gapi::serialize(cv::GComputation(a, a+10));
...

// then
auto c = cv::gapi::deserialize<cv::GComputation>(p);
// and then

c.apply(cv::gin(in_mat /*, 10 */), cv::gout(out_mat));   // without `10` in runargs, `in_mat` only

 

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dbudniko
dbudniko reviewed Jul 8, 2021
View reviewed changes
@alalek alalek merged commit 3f3c5de into opencv:master Jul 9, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@sivanov-work
Merge pull request opencv#20372 from sivanov-work:serialize
cdbfe8e 
GAPI: Implement ConstValue serialize/deserialize

* Implement ConstValue ser/deser

* Fix MacOs compile issue

* Fix Docs compile

* Change uint32 -> uint64 for serialize tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbudniko dbudniko dbudniko approved these changes

@smirnov-alexey smirnov-alexey Awaiting requested review from smirnov-alexey

@dmatveev dmatveev Awaiting requested review from dmatveev

@rgarnov rgarnov Awaiting requested review from rgarnov

Assignees

@dbudniko dbudniko

Labels

bug category: g-api / gapi

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@sivanov-work @dbudniko @alalek