Skip to content

G-API: ONNX. Skip tests.#20359

Merged
alalek merged 2 commits intoopencv:masterfrom
mpashchenkov:mp/onnx-tests
Jul 6, 2021
Merged

G-API: ONNX. Skip tests.#20359
alalek merged 2 commits intoopencv:masterfrom
mpashchenkov:mp/onnx-tests

Conversation

@mpashchenkov
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov commented Jul 5, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Magic ONNX commands:

force_builders=Custom
buildworker:Custom=linux-1
build_image:Custom=ubuntu-onnx:20.04
test_modules:Custom=gapi
test_filter:Custom=*ONNX*

TolyaTalamanov
TolyaTalamanov reviewed Jul 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss locally

TolyaTalamanov
TolyaTalamanov approved these changes Jul 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dmatveev Could you have a look ?

dmatveev
dmatveev reviewed Jul 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mpashchenkov
Copy link
Copy Markdown
Contributor Author

mpashchenkov commented Jul 6, 2021 •
edited
Loading

@alalek Can this be rebuilt (some default checks are not started) and merged?

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

TolyaTalamanov commented Jul 6, 2021

@alalek Can this be rebuilt (some default checks are not started) and merged?

Restarted

@mpashchenkov
Copy link
Copy Markdown
Contributor Author

mpashchenkov commented Jul 6, 2021

@alalek, Can it be merged? All are green.

@alalek alalek merged commit ed2a698 into opencv:master Jul 6, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#20359 from mpashchenkov:mp/onnx-tests
2bfc316 
G-API: ONNX. Skip tests.

* imread for every test

* Changed name for Yolo function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev left review comments

@TolyaTalamanov TolyaTalamanov TolyaTalamanov approved these changes

Assignees

@TolyaTalamanov TolyaTalamanov

Labels

category: g-api / gapi test

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@mpashchenkov @TolyaTalamanov @dmatveev @alalek