fix memory leak when exception is thrown#20293
Merged
alalek merged 2 commits intoopencv:masterfrom Jun 26, 2021
Merged
Conversation
alalek
reviewed
Jun 23, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
If that exception is thrown (CV_Assert(tlsSlotsSize > slotIdx);), then it means that memory is corrupted and related objects are not in a consistent state.
Memory leak is not a real problem here. This error is not "recoverable".
Looks like it is some kind of report from static analyzers.
2b3961d to
59b09d6
Compare
alalek
approved these changes
Jun 26, 2021
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
* fix memory leak when exception is thrown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
setDatamay throw an exception withoutCV_THREAD_SANITIZER.This fix is to avoid the memory leak on
pDatawhen exception is thrown.