G-API: Extend python bindings by TolyaTalamanov · Pull Request #20271 · opencv/opencv

TolyaTalamanov · 2021-06-16T07:34:11Z

Wrap timestamp, seqNo, seq_id
Wrap copy
Wrap parseSSD, parseYolo

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

* Wrap timestamp, seqNo, seq_id * Wrap copy * Wrap parseSSD, parseYolo

…end-python-bindings

TolyaTalamanov · 2021-06-18T07:55:03Z

@mpashchenkov Have a look, please

mpashchenkov · 2021-06-18T08:19:36Z

modules/python/src2/cv2.cpp

+{
+    if (!obj || obj == Py_None)
+    {
+        return true;


Why does the if return true here?

https://github.com/opencv/opencv/blob/master/modules/python/src2/cv2.cpp#L915

https://github.com/opencv/opencv/blob/master/modules/python/src2/cv2.cpp#L942

https://github.com/opencv/opencv/blob/master/modules/python/src2/cv2.cpp#L1009

@alalek Could you review this implementation, please ?

this is used for handling "default values" of arguments

modules/gapi/include/opencv2/gapi/infer.hpp

…end-python-bindings

TolyaTalamanov · 2021-06-24T08:10:24Z

@alalek @mpashchenkov Could you have a look, please ?

alalek

what is about adding of test code for new functionality?

alalek · 2021-06-24T09:44:41Z

modules/python/src2/cv2.cpp

 }

+template<>
+bool pyopencv_to(PyObject* obj, int64& value, const ArgInfo& info)


Bindings generator doesn't support int64 type in functions signatures. No plans to add that due to ambiguous using and compatibility issues with other languages. Consider using int / size_t instead.

It makes sense to add note here.

Can I implement pyopencv_to(int64_t) with static_cast to size_t ?

Main problem with size_t is that it is unsigned.

Removed this implementation. Looks like it isn't necessary to read int64 data from python so far.

alalek · 2021-06-24T09:45:45Z

modules/python/src2/cv2.cpp

+{
+    if (!obj || obj == Py_None)
+    {
+        return true;


this is used for handling "default values" of arguments

TolyaTalamanov · 2021-06-28T10:40:11Z

modules/gapi/misc/python/pyopencv_gapi.hpp

        HANDLE_CASE(RECT,    cv::Rect);
        HANDLE_CASE(UNKNOWN, cv::GArg);
        UNSUPPORTED(UINT64);
+        UNSUPPORTED(INT64);


Unsupported for pyopencv_to

TolyaTalamanov · 2021-06-28T10:41:02Z

modules/gapi/src/backends/common/gmetabackend.cpp

        return EPtr{new GraphMetaExecutable(graph, nodes)};
    }
+
+    virtual bool controlsMerge() const override


@dmatveev FYI

what is about adding of test code for new functionality?

Added test: seq_id, seqNo, timestamp.
Already testing: parseSSD, networks
Didn't add test for parseYolo since there is no suitable model on CI

TolyaTalamanov · 2021-06-28T10:42:02Z

@alalek Could you have a look, please ?

mpashchenkov · 2021-06-29T09:41:03Z

modules/gapi/misc/python/pyopencv_gapi.hpp

        {
-            PyErr_SetString(PyExc_TypeError, "Unsupported type for cv.GIn()/cv.GOut()");
-            return NULL;
+            util::throw_error(std::logic_error("Unsupported type for GProtoArgs"));


Does the message appear in error log? Why is not PyErr_SetString?

Because caller function handles this exception and setup PyErr_SetString.
https://github.com/TolyaTalamanov/opencv/blob/at/extend-python-bindings/modules/gapi/misc/python/pyopencv_gapi.hpp#L929

mpashchenkov · 2021-06-29T09:50:28Z

modules/gapi/misc/python/test/test_gapi_streaming.py

+                has_frame, (ts, seqno, seqid) = ccomp.pull()
+
+                if not has_frame:
+                    break


Should the if contain an error message?

I don't think so, in fact I just put it in case video less than 10 frames

TolyaTalamanov · 2021-06-30T08:28:38Z

@alalek Can it be merged ?

…bindings G-API: Extend python bindings * Extend G-API bindings * Wrap timestamp, seqNo, seq_id * Wrap copy * Wrap parseSSD, parseYolo * Rewrap cv.gapi.networks * Add test for metabackend in pytnon * Remove int64 pyopencv_to

Extend G-API bindings

a46daea

* Wrap timestamp, seqNo, seq_id * Wrap copy * Wrap parseSSD, parseYolo

TolyaTalamanov added category: python bindings category: g-api / gapi labels Jun 16, 2021

TolyaTalamanov added this to the 4.5.3 milestone Jun 16, 2021

TolyaTalamanov added 2 commits June 17, 2021 14:48

Rewrap cv.gapi.networks

ef4e013

Merge branch 'master' of https://github.com/opencv/opencv into at/ext…

6a8d413

…end-python-bindings

mpashchenkov reviewed Jun 22, 2021

View reviewed changes

Merge branch 'master' of https://github.com/opencv/opencv into at/ext…

91df1cf

…end-python-bindings

TolyaTalamanov requested a review from alalek June 24, 2021 08:09

alalek reviewed Jun 24, 2021

View reviewed changes

Add test for metabackend in pytnon

a998612

TolyaTalamanov force-pushed the at/extend-python-bindings branch from 75993c7 to a998612 Compare June 28, 2021 08:12

TolyaTalamanov commented Jun 28, 2021

View reviewed changes

Remove int64 pyopencv_to

dcfddce

TolyaTalamanov force-pushed the at/extend-python-bindings branch from 0f5fae4 to dcfddce Compare June 28, 2021 14:51

TolyaTalamanov requested a review from mpashchenkov June 28, 2021 19:01

mpashchenkov approved these changes Jun 29, 2021

View reviewed changes

alalek assigned mpashchenkov Jun 30, 2021

alalek merged commit fb7ef76 into opencv:master Jun 30, 2021

alalek mentioned this pull request Oct 15, 2021

(5.x) Merge 4.x #20886

Merged

Uh oh!

Conversation

TolyaTalamanov commented Jun 16, 2021

Pull Request Readiness Checklist

Build configuration

Uh oh!

TolyaTalamanov commented Jun 18, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TolyaTalamanov commented Jun 24, 2021

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Jun 28, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Jun 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants