Skip to content

Update to initInverseRectificationMap()#20247

Merged
alalek merged 3 commits intoopencv:masterfrom
IanMaquignaz:inverseRectification_update
Jun 9, 2021
Merged

Update to initInverseRectificationMap()#20247
alalek merged 3 commits intoopencv:masterfrom
IanMaquignaz:inverseRectification_update

Conversation

@IanMaquignaz
Copy link
Copy Markdown
Contributor

@IanMaquignaz IanMaquignaz commented Jun 8, 2021

Updates to initInverseRectificationMap(). Includes update to documentation and fixes to issues identified in #20165

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@IanMaquignaz IanMaquignaz mentioned this pull request Jun 9, 2021
Merged
4 tasks
@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 9, 2021

Thank you for update!
Please take a look on whitespace issues (from default/"Docs" builder).

Also you may want to install git pre-commit hook to catch them early: https://github.com/opencv/opencv/wiki/How_to_contribute#q3-i-was-asked-to-remove-whitespace-issues-how-can-i-do-that

alalek
alalek approved these changes Jun 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit 2db243b into opencv:master Jun 9, 2021
@IanMaquignaz
Copy link
Copy Markdown
Contributor Author

IanMaquignaz commented Jun 9, 2021

@alalek I haven't added the new unit test... that's why this was still a work in progress....

Guess I need a new PR to add that?

@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 9, 2021

This PR is merged to reduce testing infrastructure pressure (tests are disabled by this patch).

Yes, please create new PR with updated tests.

@IanMaquignaz IanMaquignaz mentioned this pull request Jun 11, 2021
Merged
6 tasks
@alalek alalek mentioned this pull request Jun 13, 2021
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@IanMaquignaz
Merge pull request opencv#20247 from IanMaquignaz:inverseRectificatio…
11fe74d 
…n_update

Update to initInverseRectificationMap()

* update to initInverseRectificationMap() documentation

* Restructured Calib3d_InitInverseRectificationMap unit test per feedback from alalek

* whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: calib3d

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@IanMaquignaz @alalek @asmorkalov