Skip to content

[G-API] Generic type documentation#20169

Merged
alalek merged 2 commits intoopencv:masterfrom
TolyaTalamanov:at/doc-generic-type
Jun 8, 2021
Merged

[G-API] Generic type documentation#20169
alalek merged 2 commits intoopencv:masterfrom
TolyaTalamanov:at/doc-generic-type

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented May 27, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Preview

https://pullrequest.opencv.org/buildbot/export/pr/20169/docs/

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

TolyaTalamanov
TolyaTalamanov commented May 27, 2021
View reviewed changes
@dmatveev dmatveev self-assigned this May 28, 2021
@dmatveev dmatveev added this to the 4.5.3 milestone May 28, 2021
dmatveev
dmatveev reviewed Jun 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done but can be improved slightly

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Jun 3, 2021

@dmatveev

mpashchenkov
mpashchenkov reviewed Jun 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmatveev's comments for my PR.

modules/gapi/include/opencv2/gapi/infer/ie.hpp Outdated
@param tag string tag of the network for which these parameters are intended.
@param model path to topology IR (.xml file).
@param weights path to weights (.bin file).
@param device device specifier.
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got comment, that this should be the target device to use.

Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

modules/gapi/include/opencv2/gapi/infer/ie.hpp Outdated
/** @brief Class constructor.

Constructs Params based on model information and sets default values for other
inference description parameters. Model is loaded and compiled with OpenVINO.
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenVINO -> OpenVINO Toolkit

with -> using

Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dmatveev dmatveev mentioned this pull request Jun 7, 2021
Merged
6 tasks
dmatveev
dmatveev approved these changes Jun 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalek can you please merge this one?

@alalek alalek merged commit bdc8e91 into opencv:master Jun 8, 2021
@alalek alalek mentioned this pull request Jun 13, 2021
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov
Merge pull request opencv#20169 from TolyaTalamanov:at/doc-generic-type
7fd477a 
[G-API] Generic type documentation

* Put doc about generic type

* Fix comments to review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpashchenkov mpashchenkov mpashchenkov left review comments

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: documentation Documentation fix or update category: g-api / gapi

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@TolyaTalamanov @dmatveev @mpashchenkov @alalek