Add streaming queue capacity option choice to MTCNN G-API sample#20155
Merged
alalek merged 3 commits intoopencv:masterfrom May 27, 2021
Merged
Add streaming queue capacity option choice to MTCNN G-API sample#20155alalek merged 3 commits intoopencv:masterfrom
alalek merged 3 commits intoopencv:masterfrom
Conversation
mpashchenkov
approved these changes
May 25, 2021
| "{ thrr | 0.7 | MTCNN R confidence threshold}" | ||
| "{ thro | 0.7 | MTCNN O confidence threshold}" | ||
| "{ half_scale | false | MTCNN P use half scale pyramid}" | ||
| "{ queue_capacity | 1 | Streaming executor queue capacity. Calculated automaticaly if 0}" |
Contributor
There was a problem hiding this comment.
M B -1 will be value for automatic calculation and it will be asserted for zero that queue capacity != 0.
Contributor
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
queue capacity = 0 case is documented in the sample help string. The sample will never try to provide compile args with zero queue depth by design.
| const auto target_dev_o = cmd.get<std::string>("mtcnnod"); | ||
| const auto conf_thresh_o = cmd.get<float>("thro"); | ||
| const auto use_half_scale = cmd.get<bool>("half_scale"); | ||
| const auto streaming_queue_capacity = cmd.get<unsigned int>("queue_capacity"); |
Contributor
TolyaTalamanov
left a comment
There was a problem hiding this comment.
I would exclude it from options and set to 1. But let's to discuss locally.
TolyaTalamanov
approved these changes
May 27, 2021
Author
|
@alalek could you please merge this update for MTCNN sample? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…mo_queue_option Add streaming queue capacity option choice to MTCNN G-API sample * Add streaming queue capacity option * trying to fix mac build * rename face detection sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f
build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f
Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2021.3.0
build_image:Custom Mac=openvino-2021.3.0
test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java
buildworker:Custom=linux-1
// disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*