G-API: Improvement stereo documentation.#20129
Merged
alalek merged 11 commits intoopencv:masterfrom Jun 9, 2021
Merged
Conversation
Contributor
Author
|
@dmatveev @AsyaPronina Please look |
Contributor
added 3 commits
May 28, 2021 16:41
mpashchenkov
approved these changes
May 31, 2021
alalek
reviewed
Jun 7, 2021
| @param left 8-bit single-channel image of @ref CV_8UC1 type from left source. | ||
| @param right 8-bit single-channel image of @ref CV_8UC1 type from right source. | ||
| @param left 8-bit single-channel left image of @ref CV_8UC1 type. | ||
| @param right 8-bit single-channel left image of @ref CV_8UC1 type. |
Comment on lines
27
to
+32
| Values(cv::gapi::StereoOutputFormat::DEPTH_FLOAT16, | ||
| cv::gapi::StereoOutputFormat::DEPTH_FLOAT32, | ||
| cv::gapi::StereoOutputFormat::DISPARITY_FIXED16_12_4, | ||
| cv::gapi::StereoOutputFormat::DEPTH_FLOAT16, | ||
| cv::gapi::StereoOutputFormat::DEPTH_FLOAT32, | ||
| cv::gapi::StereoOutputFormat::DISPARITY_Q16_11_4), | ||
| cv::gapi::StereoOutputFormat::DEPTH_16F, | ||
| cv::gapi::StereoOutputFormat::DEPTH_32F, | ||
| cv::gapi::StereoOutputFormat::DISPARITY_16Q_11_4), |
Member
There was a problem hiding this comment.
Do we really need to test both sets?
Contributor
There was a problem hiding this comment.
yeah the "old" enums leaked already to the internal app we provide in packages.
dmatveev
requested changes
Jun 8, 2021
dmatveev
approved these changes
Jun 9, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
Please go ahead with the merge.
Merged
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…eo_documentation G-API: Improvement stereo documentation. * Documentation improvement * Set valid default values for gapi stereo * Small doc fix * Review response * Review response * Review response * Review response * Revie response * Review response * Review response * Review response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.