Skip to content

Fix OpenCV build with OpenEXR before 2.2.0#19998

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
asmorkalov:as/openexr_version_check
Apr 29, 2021
Merged

Fix OpenCV build with OpenEXR before 2.2.0#19998
opencv-pushbot merged 1 commit intoopencv:masterfrom
asmorkalov:as/openexr_version_check

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Apr 28, 2021 •
edited
Loading

Issue #19925

OpenEXR 1.7.1 provided with CentOS 7 does not support DWAA_COMPRESSION and DWAB_COMPRESSION compression options.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov mentioned this pull request Apr 28, 2021
Closed
4 tasks
@asmorkalov asmorkalov force-pushed the as/openexr_version_check branch from a6d0a41 to 7158c47 Compare April 28, 2021 07:57
catree
catree reviewed Apr 28, 2021
View reviewed changes
modules/imgcodecs/src/grfmt_exr.cpp Outdated
case IMWRITE_EXR_COMPRESSION_B44A:
header.compression() = B44A_COMPRESSION;
break;
#if (OPENEXR_VERSION_MAJOR >= 2) && (OPENEXR_VERSION_MINOR >= 2)
Copy link
Copy Markdown
Contributor

@catree catree Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check would not work with OPENEXR_VERSION_MAJOR=3 and OPENEXR_VERSION_MINOR=0.

Copy link
Copy Markdown
Contributor Author

@asmorkalov asmorkalov Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@asmorkalov asmorkalov force-pushed the as/openexr_version_check branch from 7158c47 to 2b10be0 Compare April 28, 2021 12:09
@asmorkalov asmorkalov force-pushed the as/openexr_version_check branch from 2b10be0 to 083a7c8 Compare April 29, 2021 06:51
@opencv-pushbot opencv-pushbot merged commit 1dacea3 into opencv:master Apr 29, 2021
xkszltl added a commit to xkszltl/Roaster that referenced this pull request Apr 29, 2021
@xkszltl
Patch OpenCV 4.5.2 for old OpenEXR issues.
c3f6d58 
- opencv/opencv#19925
- opencv/opencv#19998
- opencv/opencv@083a7c8
@alalek alalek mentioned this pull request Jun 4, 2021
Merged
@xkszltl xkszltl mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@catree catree catree left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alalek alalek

Labels

bug category: build/install category: imgcodecs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asmorkalov @alalek @catree @opencv-pushbot