Merged
Conversation
added 21 commits
April 15, 2021 16:54
Author
|
@alalek I don't understand what is wrong with Ubuntu20 build. I see red error message "service under maintenance" or something like this. |
dmatveev
reviewed
Apr 20, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
I believe it looks good already!
But team please review the kernel code more carefully, had no change to dig deep into that.
added 7 commits
April 20, 2021 18:49
dmatveev
approved these changes
Apr 22, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
Please be more careful with the output. Most of my comments are suggestions for improvements and are not blocking the merge.
Author
|
@alalek CI is green. 2 reviewers approved this PR. Can we merge it? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…mo_PR G-API MTCNN sample * add face detection demo * clean up * enable back accumulate * additional input * meta args workaround * additional arg * add init * roll back * fix shadowing * roll back * clean up and PNet copy from debug branch which now works * try nets operator * more clean up * more clean up * add 6 layers pyramid experimental code * final clean up and ready for PR * original image resize * Remove Pnet declarations. Generic infer is used now. * scales and sizes calculation added * fix assert, and add ceil to size calculation * try doubles for scales * Address comments from Dmitry. * use half scale option * fix half scale * clean up debug outputs * try to get input image width and height * clean up * trailing spaces and review from Maxim * more comments from Maxim are addressed * try to fix warnings * try to fix warnings and address more comments from Dmitry * crop fix and clean up * more warnings fixes * more warnings fixes * more comments from Maxim are addressed * even more consts * copy_n for regressions * address more comments from Dmitry * more comments from Maxim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.