[G-API] Fix bug of GArray<GArray> passing through a graph#19828
Merged
alalek merged 4 commits intoopencv:masterfrom Apr 1, 2021
Merged
[G-API] Fix bug of GArray<GArray> passing through a graph#19828alalek merged 4 commits intoopencv:masterfrom
alalek merged 4 commits intoopencv:masterfrom
Conversation
- Also: Fix formatting in garray.hpp
dmatveev
approved these changes
Apr 1, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
Must be ok but please test more carefully
Contributor
|
@alalek that's the 2nd part of the hotfix (now validated with a test) |
AsyaPronina
approved these changes
Apr 1, 2021
Contributor
Author
|
@alalek fix & test reviewed, ready for merging |
Contributor
|
Fantastic, thanks! |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…input [G-API] Fix bug of GArray<GArray> passing through a graph * Add test to check GArray<GArray> passing through a graph (assertion failed) * G-API: Flatten GArray<T> to std::vector<T> when capturing VCtr - Also: Fix formatting in garray.hpp * Refactored test, added valuable check * Initialize size_t Co-authored-by: Dmitry Matveev <dmitry.matveev@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If GArray<GArray> wasn't an input or an output of a graph, assertion would fail.
Added test to check the fix works
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.