G-API: ONNX. Adding INT64-32 conversion for output.#19752
Merged
alalek merged 17 commits intoopencv:masterfrom Mar 30, 2021
Merged
G-API: ONNX. Adding INT64-32 conversion for output.#19752alalek merged 17 commits intoopencv:masterfrom
alalek merged 17 commits intoopencv:masterfrom
Conversation
Contributor
|
@mpashchenkov pay attention that |
OrestChura
reviewed
Mar 26, 2021
OrestChura
approved these changes
Mar 29, 2021
dmatveev
approved these changes
Mar 29, 2021
Comment on lines
+206
to
+207
| std::transform(ptr, ptr + total, mt_ptr, | ||
| [](int64_t el) { return static_cast<int>(el); }); |
Contributor
There was a problem hiding this comment.
hmm what about strides? I'd put an assert here expecting a Mat is continuous.
Member
There was a problem hiding this comment.
It makes sense to place checks before related statements.
Contributor
Author
There was a problem hiding this comment.
Changed. But i don't see where gap can appear in Mat for current implementation.
Contributor
Author
|
@TolyaTalamanov, please check last update before merge. |
added 13 commits
March 30, 2021 13:38
d0a620f to
c1ce9f2
Compare
added 3 commits
March 30, 2021 14:03
TolyaTalamanov
approved these changes
Mar 30, 2021
Member
|
Why is build configuration not enabled to check ONNX code? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
G-API: ONNX. Adding INT64-32 conversion for output. * Added int64 to 32 conversion * Added warning * Added type checks for all toCV * Added type checks for tests * Small fixes * Const for fixture in test * std::tuple if retutn value for toCV * Mistake * Changed toCV for tests * Added Assert * Fix for comments * One conversion for ONNX and IE * Clean up * One more fix * Added copyFromONNX * Removed warning * Apply review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding INT64-32 conversion for output.
ONNX's RCNN contains output (labels) with INT64 type.
INT64 type isn't supported for cv::Mat. Conversion to INT32 is used for this output.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Custom build: