Skip to content

core:ppc64 fix the build with the newer versions of Eigen on IBM/Power#19692

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
seiko2plus:issue_19647
Mar 9, 2021
Merged

core:ppc64 fix the build with the newer versions of Eigen on IBM/Power#19692
opencv-pushbot merged 1 commit intoopencv:3.4from
seiko2plus:issue_19647

Conversation

@seiko2plus
Copy link
Copy Markdown
Contributor

@seiko2plus seiko2plus commented Mar 8, 2021 •
edited by alalek
Loading

closes #19647

It also fixes the build when universal intrinsics is disabled via -DDCV_ENABLE_INTRINSICS=OFF.

force_builders=Linux AVX2,Custom
buildworker:Custom=linux-1,linux-2,linux-4
build_image:Custom=powerpc64le
disable_ipp=ON

@seiko2plus seiko2plus mentioned this pull request Mar 8, 2021
Closed
@asmorkalov asmorkalov requested a review from alalek March 9, 2021 08:23
@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 9, 2021

@seiko2plus Thank you!

As a "bug fix" this patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Mar 9, 2021
@smuzaffar
[OpenCV] Apply opencv/opencv#19692 to fix ppc64le build issues with e…
430a385 
…igen
@smuzaffar smuzaffar mentioned this pull request Mar 9, 2021
Merged
@seiko2plus seiko2plus changed the base branch from master to 3.4 March 9, 2021 17:16
@seiko2plus
core:ppc64 fix the build with the newer versions of Eigen on IBM/Power
84fcc4a 
   It also fixes the build when universal intrinsics is disabled
   via `-DDCV_ENABLE_INTRINSICS=OFF`.
@seiko2plus
Copy link
Copy Markdown
Contributor Author

seiko2plus commented Mar 9, 2021

@alalek, done

alalek
alalek approved these changes Mar 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 1d6a1e5 into opencv:3.4 Mar 9, 2021
smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Mar 9, 2021
@smuzaffar
Merge pull request #6707 from cms-sw/smuzaffar-patch-6
3d583be 
[OpenCV] Apply opencv/opencv#19692 to fix ppc64le build issues with eigen
@alalek alalek mentioned this pull request Mar 13, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: build/install category: core platform: ppc (PowerPC)

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

Error compiling with newer Eigen on PPC64LE

4 participants

@seiko2plus @alalek @opencv-pushbot @asmorkalov