getCacheDirectory binding for Python#19668
Merged
alalek merged 2 commits intoopencv:masterfrom Mar 4, 2021
Merged
Conversation
alalek
reviewed
Mar 3, 2021
| } | ||
| //! @} | ||
| }} // namespace | ||
| }} // namespace fs |
modules/core/src/bindings_utils.cpp
Outdated
| #if OPENCV_HAVE_FILESYSTEM_SUPPORT | ||
| return cv::utils::fs::getCacheDirectory("downloads", "OPENCV_DOWNLOADS_CACHE_DIR"); | ||
| #else | ||
| CV_Error(Error::StsNotImplemented, "File system support was disabled during OpenCV build!"); |
Member
There was a problem hiding this comment.
was disabled during OpenCV build
"is disabled in this OpenCV build" ?
| try: | ||
| self.assertTrue(os.path.exists(path)) | ||
| self.assertTrue(os.path.isdir(path)) | ||
| os.rmdir(path) |
Member
There was a problem hiding this comment.
Do we really need to remove any "external" directory in tests? We don't own this.
| finally: | ||
| os.remove(test_file_name) | ||
|
|
||
| self.assertEqual(cv.norm(gold_image - read_from_file), 0) |
Member
There was a problem hiding this comment.
gold_image - read_from_file
Use 2 args instead of subtraction (it doesn't work correct with overflows/underflows)
| } | ||
|
|
||
| namespace fs { | ||
| CV_EXPORTS_AS(getCacheDirectory) cv::String getCacheDirectoryForDownloads(); |
Member
There was a problem hiding this comment.
why we should rename that?
This would cause confusion between C++ and Python getCacheDirectory() functions.
a0f6210 to
1bc7810
Compare
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
* Add Python Bindings for getCacheDirectory function * Added getCacheDirectory interop test with image codecs. Co-authored-by: Sergey Slashchinin <sergei.slashchinin@xperience.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #18931 and adds more test for imgcodecs interop.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.