calib3d(usac): do not crash on empty models#19640
Merged
alalek merged 3 commits intoopencv:masterfrom Feb 28, 2021
Merged
Conversation
alalek
commented
Feb 28, 2021
| inline bool isModelGood(const Mat& model) override | ||
| { | ||
| if (model.empty()) | ||
| return false; |
Member
Author
Contributor
There was a problem hiding this comment.
Yes it is. However, the situation that model comes empty to SPRT should not have happened in general. Maybe there is a problem somewhere else, I'll check it. For function setModelParameters CV_CheckTypeEQ(model.depth(), CV_64F, ""); it is a bit redundant because the model will always be in double format. It comes from solver.
ivashmak
approved these changes
Feb 28, 2021
Member
Author
|
👍 |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
calib3d(usac): do not crash on empty models * calib3d(test): regression test for issue 19639 * calib3d(usac): do not crash in setModelParameters() * calib3d(usac): handle empty models in isModelGood()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #19639
relates #17683