get and set cameras on stitcher#19619
Merged
alalek merged 2 commits intoopencv:masterfrom Mar 9, 2021
Merged
Conversation
asmorkalov
requested changes
Feb 25, 2021
amirtu
commented
Mar 1, 2021
modules/stitching/src/stitcher.cpp
Outdated
| return OK; | ||
| } | ||
|
|
||
| Stitcher::Status Stitcher::setTransform(InputArrayOfArrays images, const std::vector<detail::CameraParams> &cameras) { |
Member
Author
There was a problem hiding this comment.
Probably the following code is excessive, as the same result could be achieved by reusing an initialized (through estimateTransform) stitcher's composePanorama with updated images (i.e. different from those passed to estimateTransform). In other words, it would be sufficient to provide only a setter to the homographies (cameras array).
asmorkalov
reviewed
Mar 1, 2021
asmorkalov
reviewed
Mar 5, 2021
alalek
reviewed
Mar 9, 2021
Comment on lines
+7
to
+10
| namespace opencv_test { namespace { | ||
|
|
||
| TEST(Stitching_Stitcher_setTransform, issue_18459) | ||
| { |
Member
There was a problem hiding this comment.
Need to remove indentation from namespaces
| */ | ||
| CV_WRAP Status estimateTransform(InputArrayOfArrays images, InputArrayOfArrays masks = noArray()); | ||
|
|
||
| /** @overload */ |
Member
There was a problem hiding this comment.
Overloads should go after the main function.
It differs from the above function only in what argument(s) it accepts.
5cfe446 to
68c3a75
Compare
asmorkalov
approved these changes
Mar 9, 2021
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…as_on_stitcher * Get and set cameras for sticher. * Code review fixes. Co-authored-by: amir.tulegenov <amir.tulegenov@xperience.ai> Co-authored-by: Alexander Smorkalov <alexander.smorkalov@xperience.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #18459
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.