Skip to content

Render Frame NV12 on CPU#19516

Merged
alalek merged 8 commits intoopencv:masterfrom
dbudniko:dbudniko/gapi_render_frame_cpu
Feb 15, 2021
Merged

Render Frame NV12 on CPU#19516
alalek merged 8 commits intoopencv:masterfrom
dbudniko:dbudniko/gapi_render_frame_cpu

Conversation

@dbudniko
Copy link
Copy Markdown

@dbudniko dbudniko commented Feb 12, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [x ] I agree to contribute to the project under Apache 2 License.
  • [x ] To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • [x ] The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
Xbuild_image:Custom Win=openvino-2020.3.0
Xbuild_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
// disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

smirnov-alexey
smirnov-alexey reviewed Feb 12, 2021
View reviewed changes
smirnov-alexey
smirnov-alexey reviewed Feb 12, 2021
View reviewed changes
smirnov-alexey
smirnov-alexey approved these changes Feb 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smirnov-alexey smirnov-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I would recommend to get one more review though

rgarnov
rgarnov requested changes Feb 15, 2021
View reviewed changes
rgarnov
rgarnov requested changes Feb 15, 2021
View reviewed changes
rgarnov
rgarnov requested changes Feb 15, 2021
View reviewed changes
@alalek alalek merged commit 0cdbdfd into opencv:master Feb 15, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#19516 from dbudniko:dbudniko/gapi_render_fr…
3765480 
…ame_cpu

Render Frame NV12 on CPU

* render frame on CPU

* doxygen fix

* address review from Alexey

* comment fixes

* Address comments from Ruslan

* remove NV12 specific

* mat clone and more renaming

* misprint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgarnov rgarnov rgarnov approved these changes

@smirnov-alexey smirnov-alexey smirnov-alexey approved these changes

@dmatveev dmatveev Awaiting requested review from dmatveev

@AsyaPronina AsyaPronina Awaiting requested review from AsyaPronina

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

Assignees

@rgarnov rgarnov

Labels

category: g-api / gapi feature test

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@dbudniko @rgarnov @smirnov-alexey @asmorkalov @alalek