[G-API]: Performance tests for kmeans#19497
Merged
alalek merged 2 commits intoopencv:masterfrom Feb 25, 2021
Merged
Conversation
- New file for common parts of acc. and perf. tests for core kernels added - Some typos corrections
Contributor
Author
|
@aDanPin please take a look |
aDanPin
approved these changes
Feb 12, 2021
Contributor
aDanPin
left a comment
There was a problem hiding this comment.
Everything except for two small comments looks good to me
Have a good merge!
Contributor
mpashchenkov
left a comment
There was a problem hiding this comment.
First wave. Thanks.
| bestLabelsMat.copyTo(labels_ocv); | ||
| } | ||
| // OpenCV code ///////////////////////////////////////////////////////////// | ||
| double compact_ocv = cv::kmeans(in, K, labels_ocv, criteria, attempts, flags, centers_ocv); |
Contributor
There was a problem hiding this comment.
const, but it is a cavil.
Contributor
Author
There was a problem hiding this comment.
Yeah, I don't think this changes much. Let it be non-const
mpashchenkov
approved these changes
Feb 19, 2021
Contributor
Author
|
@alalek, is this mergeable? |
Member
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
[G-API]: Performance tests for kmeans * - Perf.Tests for kmeans(2D, 3D (Point2f/3f), ND (Mat)) - New file for common parts of acc. and perf. tests for core kernels added - Some typos corrections * Applying comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.