Skip to content

[G-API] Change memory measurement statistic in Fluid tests#19496

Merged
alalek merged 2 commits intoopencv:masterfrom
andrey-golubev:master
Feb 17, 2021
Merged

[G-API] Change memory measurement statistic in Fluid tests#19496
alalek merged 2 commits intoopencv:masterfrom
andrey-golubev:master

Conversation

@andrey-golubev
Copy link
Copy Markdown
Member

@andrey-golubev andrey-golubev commented Feb 10, 2021 •
edited by alalek
Loading

Based on recent discussion in a related bug report (#19434), let's change the statistic used to measure the "memory consumption"

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
build_image:Custom=centos:7
buildworker:Custom=linux-1,linux-4,linux-6
test_modules:Custom=gapi

@andrey-golubev
Copy link
Copy Markdown
Member Author

andrey-golubev commented Feb 10, 2021 •
edited
Loading

Not the nicest solution but that should do it for now.

CC: @alalek
CC: @dmatveev

andrey-golubev
andrey-golubev commented Feb 10, 2021
View reviewed changes
asmorkalov
asmorkalov approved these changes Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It looks like the solution works. I run g-api tests on ARM system several times, but have not reproduced the test failure.

@alalek alalek merged commit b50c1ba into opencv:master Feb 17, 2021
@andrey-golubev
Copy link
Copy Markdown
Member Author

andrey-golubev commented Feb 17, 2021

Awesome, thanks!

@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@andrey-golubev
Merge pull request opencv#19496 from andrey-golubev:master
1b98534 
[G-API] Change memory measurement statistic in Fluid tests

* Change memory measurement statistic in Fluid tests

* Delete irrelevant comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: g-api / gapi test

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

Test Fluid.MemoryConsumptionDoesNotGrowOnReshape is unstable on Linux

3 participants

@andrey-golubev @asmorkalov @alalek