[G-API] Support multiple asynchronous requests by TolyaTalamanov · Pull Request #19487 · opencv/opencv

TolyaTalamanov · 2021-02-09T13:35:25Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Build configuration

Xforce_builders_only=linux,docs
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.1.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.1.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

modules/gapi/include/opencv2/gapi/infer/ie.hpp

modules/gapi/src/backends/ie/giebackend.cpp

…port-nireq-option

dmatveev · 2021-02-12T17:56:37Z

It seems a rebase is required

dmatveev · 2021-02-12T17:56:55Z

@TolyaTalamanov can you please rebase to make the changeset clear?

…port-nireq-option

modules/gapi/src/compiler/gislandmodel.hpp

modules/gapi/src/executor/conc_queue.hpp

dmatveev

Reviewed ~40%, but didn't review the actual asynchronous pool part. Please clean-up code first (and, if possible, isolate changes for a single infer only.

dmatveev · 2021-02-17T10:58:52Z

modules/gapi/include/opencv2/gapi/infer/ie.hpp

        IEConfig config;
+
+        // NB: Number of asyncrhonious infer requests
+        size_t nireq;


Just wondering why this and the above variables are not initialized by default.

Initially it was just num_in / num_out I've left empty for some reason (as those are always initialized in ctor), but now it doesn't looks so good.

Didn't get your point, now it is initialized in ctor. What's the problem ?

The problem is when a new ctor is added (who knows), these fields may left uninitialized

Partial initialization isn't supported in C++11

modules/gapi/include/opencv2/gapi/infer/ie.hpp

modules/gapi/src/backends/ie/giebackend.cpp

modules/gapi/src/executor/gstreamingexecutor.cpp

modules/gapi/src/backends/ie/giebackend.cpp

dmatveev

Let's setup an overview call tomorrow.

What can be done for sure now is moving the async worker pool into something generic and unit-testable

modules/gapi/include/opencv2/gapi/infer/ie.hpp

modules/gapi/src/backends/ie/giebackend.cpp

…port-nireq-option

dmatveev

Approved if tests pass

modules/gapi/src/backends/ie/giebackend.cpp

TolyaTalamanov · 2021-02-26T10:02:50Z

@alalek

alalek · 2021-02-26T10:26:33Z

modules/gapi/src/backends/ie/giebackend.cpp

+    return requests;
+}
+
+class cv::gimpl::ie::RequestPool {


class cv::gimpl::ie::RequestPool {
struct RequestPool;

Warning on "Custom Win" builder:

C:\build\precommit_custom_windows\opencv\modules\gapi\src\backends\ie\giebackend.cpp(497): warning C4099: 'cv::gimpl::ie::RequestPool': type name first seen using 'struct' now seen using 'class' [C:\build\precommit_custom_windows\build\modules\gapi\opencv_gapi.vcxproj]

"Custom Mac":

/build/precommit_custom_mac/opencv/modules/gapi/src/backends/ie/giebackend.cpp:497:1: warning: 'RequestPool' defined as a class here but previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]

TolyaTalamanov · 2021-02-26T12:06:32Z

@alalek

…option [G-API] Support multiple asynchronous requests * Support nireq option * Disable tests to check CI * Fix bug with hanging * WA to green CI * Snapshot * Simplify RequestPool * Add default values to id * Fix win warning

Support nireq option

448962b

TolyaTalamanov commented Feb 9, 2021

View reviewed changes

TolyaTalamanov added 3 commits February 12, 2021 12:33

Merge branch 'master' of https://github.com/opencv/opencv into at/sup…

7ed698b

…port-nireq-option

Disable tests to check CI

dc468b6

Fix bug with hanging

4c284db

Merge branch 'master' of https://github.com/opencv/opencv into at/sup…

9bdd303

…port-nireq-option

TolyaTalamanov commented Feb 16, 2021

View reviewed changes

modules/gapi/src/compiler/gislandmodel.hpp Outdated Show resolved Hide resolved

modules/gapi/src/executor/conc_queue.hpp Outdated Show resolved Hide resolved

WA to green CI

5d3a219

dmatveev reviewed Feb 17, 2021

View reviewed changes

TolyaTalamanov force-pushed the at/support-nireq-option branch 2 times, most recently from 2ada749 to 13d7c1b Compare February 19, 2021 09:56

Snapshot

eaa36ff

TolyaTalamanov force-pushed the at/support-nireq-option branch from 13d7c1b to 5db2378 Compare February 19, 2021 11:22

TolyaTalamanov commented Feb 19, 2021

View reviewed changes

TolyaTalamanov force-pushed the at/support-nireq-option branch 2 times, most recently from 19be9a6 to 3a97e94 Compare February 19, 2021 12:24

TolyaTalamanov commented Feb 19, 2021

View reviewed changes

modules/gapi/src/executor/gstreamingexecutor.cpp Show resolved Hide resolved

TolyaTalamanov commented Feb 19, 2021

View reviewed changes

modules/gapi/src/backends/ie/giebackend.cpp Outdated Show resolved Hide resolved

TolyaTalamanov force-pushed the at/support-nireq-option branch from 3a97e94 to 161a880 Compare February 19, 2021 13:02

dmatveev reviewed Feb 19, 2021

View reviewed changes

Merge branch 'master' of https://github.com/opencv/opencv into at/sup…

d265a86

…port-nireq-option

TolyaTalamanov force-pushed the at/support-nireq-option branch 2 times, most recently from ff27092 to 115231f Compare February 24, 2021 13:35

Simplify RequestPool

ea0cf6f

TolyaTalamanov force-pushed the at/support-nireq-option branch from 115231f to ea0cf6f Compare February 24, 2021 13:47

dmatveev reviewed Feb 25, 2021

View reviewed changes

modules/gapi/src/backends/ie/giebackend.cpp Outdated Show resolved Hide resolved

modules/gapi/src/backends/ie/giebackend.cpp Outdated Show resolved Hide resolved

Add default values to id

f413e1c

alalek reviewed Feb 26, 2021

View reviewed changes

Fix win warning

49a9547

alalek assigned dmatveev Feb 26, 2021

alalek merged commit 28c064f into opencv:master Feb 26, 2021

alalek mentioned this pull request Apr 9, 2021

(5.x) Merge 4.x #19885

Merged

Uh oh!

Conversation

TolyaTalamanov commented Feb 9, 2021

Pull Request Readiness Checklist

Build configuration

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmatveev commented Feb 12, 2021

Uh oh!

dmatveev commented Feb 12, 2021

Uh oh!

Uh oh!

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

dmatveev Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

dmatveev Feb 19, 2021

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov Feb 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TolyaTalamanov commented Feb 26, 2021

Uh oh!

alalek Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov Feb 26, 2021

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Feb 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

alalek Feb 26, 2021 •

edited

Loading