Skip to content

Switched to v1 Multiply#19479

Merged
alalek merged 2 commits intoopencv:masterfrom
ilyachur:remove_v0_multiply
Feb 9, 2021
Merged

Switched to v1 Multiply#19479
alalek merged 2 commits intoopencv:masterfrom
ilyachur:remove_v0_multiply

Conversation

@ilyachur
Copy link
Copy Markdown
Contributor

@ilyachur ilyachur commented Feb 8, 2021 •
edited by dkurt
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2021.2.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@ilyachur
Copy link
Copy Markdown
Contributor Author

ilyachur commented Feb 8, 2021

@dkurt Please have a look. I think it will work only with the next OV release. Should I add any macros?

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Feb 9, 2021

@ilyachur, yes, please add a macro for new version. 2021.2 has v1::Multiply with a bug

@ilyachur ilyachur mentioned this pull request Feb 9, 2021
Merged
dkurt
dkurt approved these changes Feb 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dkurt dkurt self-assigned this Feb 9, 2021
@alalek alalek merged commit 8fa0133 into opencv:master Feb 9, 2021
@ilyachur ilyachur deleted the remove_v0_multiply branch February 9, 2021 09:54
generalova-kate pushed a commit to openvinotoolkit/docker_ci that referenced this pull request Feb 12, 2021
@dpigasin @generalova-kate
fix: add IE version cmake parameter because opencv/opencv#19479
f627455
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ilyachur @dkurt @alalek