Merged
Conversation
Member
I believe it is a time to configure git hooks: https://github.com/opencv/opencv/wiki/How_to_contribute |
ee439d4 to
1b0200d
Compare
TolyaTalamanov
commented
Jan 31, 2021
| validate(); | ||
| } | ||
|
|
||
| TEST(Infer, TestStreamingInfer) |
Contributor
Author
There was a problem hiding this comment.
Again huge code duplication, should it be solved in separate task ?
Contributor
Author
There was a problem hiding this comment.
Filed a task.
TolyaTalamanov
commented
Jan 31, 2021
2d38880 to
dd6c8e3
Compare
TolyaTalamanov
commented
Feb 1, 2021
dd6c8e3 to
eb1287b
Compare
eb1287b to
1342438
Compare
Contributor
Author
|
@AsyaPronina @smirnov-alexey Could you have a look ? |
Contributor
Author
|
@AsyaPronina could you have a look ? |
dmatveev
reviewed
Feb 8, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
No clear change overview given in the description :(
7148c07 to
29742d8
Compare
29742d8 to
c690ece
Compare
dmatveev
approved these changes
Feb 12, 2021
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
Cool, let's merge this!
Waiting for nireq to come!
Contributor
Author
alalek
reviewed
Feb 16, 2021
| inline IE::Blob::Ptr extractBlob(IECallContext& ctx, std::size_t i, Views& views) { | ||
| switch (ctx.in_shapes[i]) { | ||
| inline IE::Blob::Ptr extractBlob(IECallContext& ctx, std::size_t i) { | ||
| switch (ctx.inShape(i)) { |
Member
There was a problem hiding this comment.
@TolyaTalamanov
There are several warnings in Windows builds with IE.
Please take a look.
C:\build\precommit_custom_windows\opencv\modules\gapi\src\backends\ie\giebackend.cpp(467): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [C:\build\precommit_custom_windows\build\modules\gapi\opencv_gapi.vcxproj]
C:\build\precommit_custom_windows\opencv\modules\gapi\src\backends\ie\giebackend.cpp(631): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [C:\build\precommit_custom_windows\build\modules\gapi\opencv_gapi.vcxproj]
C:\build\precommit_custom_windows\opencv\modules\gapi\src\backends\ie\giebackend.cpp(660): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [C:\build\precommit_custom_windows\build\modules\gapi\opencv_gapi.vcxproj]
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
[G-API] Implement async infer * Implement async infer * Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.