Skip to content

videoio(plugins): support VideoCaptureParameters, CAPTURE_API_VERSION=1#19413

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
alalek:videoio_plugins_capture_params
Jan 28, 2021
Merged

videoio(plugins): support VideoCaptureParameters, CAPTURE_API_VERSION=1#19413
opencv-pushbot merged 1 commit intoopencv:masterfrom
alalek:videoio_plugins_capture_params

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jan 28, 2021 •
edited
Loading

relates #19394
relates #16766

Validation:

  • --gtest_filter=*ffmpeg*with_property*
  • with/without cmake ... -DVIDEOIO_PLUGIN_LIST=all

Note: FFmpeg Windows wrapper is not updated.

force_builders=Linux32,Win32,Custom
build_image:Custom=centos:7
buildworker:Custom=linux-1

alalek
alalek commented Jan 28, 2021
View reviewed changes
modules/videoio/src/cap.cpp

VideoCapture::VideoCapture(const String& filename, int apiPreference, const std::vector<int>& params)
: throwOnFail(true)
: throwOnFail(false)
Copy link
Copy Markdown
Member Author

@alalek alalek Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled exceptions from constructor again:

  • there is no API yet to propagate plugins exceptions
  • keep similar behavior between constructors

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jan 28, 2021

👍

@opencv-pushbot opencv-pushbot merged commit 900051c into opencv:master Jan 28, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin Awaiting requested review from mshabunin

@VadimLevin VadimLevin Awaiting requested review from VadimLevin

Assignees

@alalek alalek

Labels

category: videoio feature

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

2 participants

@alalek @opencv-pushbot