feature: Extend VideoWriter to accept vector of parameters by VadimLevin · Pull Request #16766 · opencv/opencv

VadimLevin · 2020-03-10T07:54:14Z

Added additional constructor and open method for VideoWriter
those accept a vector of parameters
Moved the actual implementation of the VideoWriter::open to the general method
which accepts a vector of parameters
Propagate parsed parameters map up to actual video backend construction

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under OpenCV (BSD) License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

build_image:Custom=centos:7
buildworker:Custom=linux-1

force_builders=Custom Win
build_image:Custom Win=msvs2019

modules/videoio/include/opencv2/videoio.hpp

asmorkalov · 2020-04-06T15:41:02Z

@vpisarev @alalek Can we merge the patch?

vpisarev

ready to merge, I think 👍

modules/videoio/include/opencv2/videoio.hpp

modules/videoio/src/backend.hpp

modules/videoio/src/backend_plugin.cpp

modules/videoio/src/cap.cpp

- Add additional constructor and `open` method for `VideoWriter` those accept a vector of parameters - Move actual implementation of the `VideoWriter::open` to general method which accepts vector of parameters - Propagate parsed parameters map up to actual video backend construction

alalek · 2020-04-21T20:34:08Z

modules/videoio/include/opencv2/videoio.hpp

    @param frameSize Size of the video frames.
    @param isColor If it is not zero, the encoder will expect and encode color frames, otherwise it
-    will work with grayscale frames (the flag is currently supported on Windows only).
+    will work with grayscale frames (the flag is ignored on MSMF and Intel MFX backends).


the flag is ignored

It is better to keep here common information only.
Backend-specific information should be moved on dedicated pages (there is huge amount of implementation details)

Does (the flag may be ignored by some backends. For more information refer to backend implementation) sound better?

I would prefer to keep this info in a single place (to avoid manual maintenance in different places).

See here:
https://github.com/opencv/opencv/blame/4.3.0/modules/videoio/doc/videoio_overview.markdown#L27

I believe the header of properties enumeration should be enough.

Thank you, got it!

jomade · 2021-09-17T08:40:00Z

Hi!
With these changes - is it really possible to set VIDEOWRITER_PROP_IS_COLOR =0? I mean, the parameter list accepts only the "identifier" VIDEOWRITER_PROP_IS_COLOR but no value to that property. I think one should integrate a VIDEOWRITER_PROP_IS_GRAYSCALE or sth like that to be able to actually use this flag.

alalek · 2021-09-17T10:16:59Z

Enum's documentation clearly states which values are accepted.
Passed values are pairs of ints.
Also check implementation of bool VideoWriter::open on this PR's diff.

jomade · 2021-09-17T10:43:16Z

Sorry, I didn't check the first doxygen-comment of the overloaded function. And from the API with const std::vector<int>& params it was not clear to me that this would be pairs. I would have expected sth like const std::vector<std::pair<int, int>>. Sorry for the noise.

asmorkalov · 2021-09-20T05:14:29Z

@jomade The std::verctor can be easily wrapped to Python, Java and other supported language bindings. It's the main reson why, it's not vector of pair, map or other structures.

…er_params_constructor * feature: Extend VideoWriter to accept vector of parameters - Add additional constructor and `open` method for `VideoWriter` those accept a vector of parameters - Move actual implementation of the `VideoWriter::open` to general method which accepts vector of parameters - Propagate parsed parameters map up to actual video backend construction * fix: Change VideoWriter constructor description to suppress doc warning * refactor: Rollback newlines changes * feature: Changed VideoWriter parameters workflow * feature: Log unused parameters in VideoWriter open * doc: Fix VideoWriter `isColor` parameter description * fix: int to bool VC++ conversion warning * doc: Remove information about `isColor` flag usage.

VadimLevin added feature category: videoio labels Mar 10, 2020

VadimLevin force-pushed the dev/vlevin/video_writer_params_constructor branch 2 times, most recently from ae035fd to 192620f Compare March 10, 2020 08:51

Kaustubh72 suggested changes Mar 18, 2020

View reviewed changes

modules/videoio/include/opencv2/videoio.hpp Outdated Show resolved Hide resolved

asmorkalov assigned vpisarev Apr 6, 2020

vpisarev approved these changes Apr 8, 2020

View reviewed changes

alalek reviewed Apr 9, 2020

View reviewed changes

modules/videoio/include/opencv2/videoio.hpp Outdated Show resolved Hide resolved

modules/videoio/src/backend.hpp Show resolved Hide resolved

modules/videoio/src/backend_plugin.cpp Outdated Show resolved Hide resolved

modules/videoio/src/cap.cpp Outdated Show resolved Hide resolved

VadimLevin added 4 commits April 20, 2020 10:53

fix: Change VideoWriter constructor description to suppress doc warning

e2e2d59

refactor: Rollback newlines changes

fecc617

feature: Changed VideoWriter parameters workflow

191dd2f

VadimLevin force-pushed the dev/vlevin/video_writer_params_constructor branch from 192620f to e9b918e Compare April 20, 2020 09:29

VadimLevin added 2 commits April 20, 2020 12:56

feature: Log unused parameters in VideoWriter open

24e0d02

doc: Fix VideoWriter isColor parameter description

ef3a44a

VadimLevin force-pushed the dev/vlevin/video_writer_params_constructor branch from e9b918e to ef3a44a Compare April 20, 2020 09:57

fix: int to bool VC++ conversion warning

7c2c8a8

VadimLevin force-pushed the dev/vlevin/video_writer_params_constructor branch from 9abd2e2 to 7c2c8a8 Compare April 20, 2020 12:31

VadimLevin requested a review from alalek April 20, 2020 13:30

alalek reviewed Apr 21, 2020

View reviewed changes

doc: Remove information about isColor flag usage.

8ccaaec

alalek merged commit 7f90f04 into opencv:master Apr 28, 2020

This was referenced Jan 25, 2021

add video capture parameters #19394

Merged

videoio(plugins): support VideoCaptureParameters, CAPTURE_API_VERSION=1 #19413

Merged

alalek mentioned this pull request Aug 20, 2021

OE-XX: Hardware-accelerated Video I/O #19676

Open

Uh oh!

Conversation

VadimLevin commented Mar 10, 2020 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

Uh oh!

asmorkalov commented Apr 6, 2020

Uh oh!

vpisarev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

VadimLevin Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

alalek Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

VadimLevin Apr 27, 2020

Choose a reason for hiding this comment

Uh oh!

jomade commented Sep 17, 2021

Uh oh!

alalek commented Sep 17, 2021

Uh oh!

jomade commented Sep 17, 2021

Uh oh!

asmorkalov commented Sep 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

VadimLevin commented Mar 10, 2020 •

edited by alalek

Loading

vpisarev left a comment •

edited

Loading