G-API: Removing ParseSSD overload.#19341
Merged
alalek merged 2 commits intoopencv:masterfrom Jun 15, 2021
Merged
Conversation
Contributor
TolyaTalamanov
left a comment
There was a problem hiding this comment.
parseFBL and parseSSDOOB look confusing. Suggest to keep both of them as a single operation parseSSD and it have to have single implementation as well.
From my point of view need to redesign input parameters.
dkurt
reviewed
Jan 18, 2021
dkurt
reviewed
Jan 18, 2021
a00599e to
893ae82
Compare
Contributor
|
jenkins cn please retry a build |
fc68359 to
b280d29
Compare
Contributor
|
@mpashchenkov is this PR still actual or you have another solution now? Where did that clean-up happen? Should we close this one? |
Contributor
Author
|
@dmatveev, this PR contains the last decision we made. It is actual. |
TolyaTalamanov
approved these changes
Jun 15, 2021
TolyaTalamanov
approved these changes
Jun 15, 2021
Contributor
|
@alalek Can it be merged ? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…d-fix G-API: Removing ParseSSD overload. * Removed specialization. * Removed united
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseSSD overload is ambiguous.
Added specialization for ParseSSD functions with different return values. Unfortunately needs call
cv::gapi::parseSSD<GArray<Rect>>for second version of ParseSSD. But all samples use first version of ParseSSD with tuple in return value.Returned overloads, removed defaults from second function variant.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Magic commands: