Skip to content

G-API: Removing ParseSSD overload.#19341

Merged
alalek merged 2 commits intoopencv:masterfrom
mpashchenkov:mp/ocv-gapi-parsessd-fix
Jun 15, 2021
Merged

G-API: Removing ParseSSD overload.#19341
alalek merged 2 commits intoopencv:masterfrom
mpashchenkov:mp/ocv-gapi-parsessd-fix

Conversation

@mpashchenkov
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov commented Jan 18, 2021

parseSSD overload is ambiguous.

Added specialization for ParseSSD functions with different return values. Unfortunately needs call cv::gapi::parseSSD<GArray<Rect>> for second version of ParseSSD. But all samples use first version of ParseSSD with tuple in return value.

Returned overloads, removed defaults from second function variant.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Magic commands:

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parseFBL and parseSSDOOB look confusing. Suggest to keep both of them as a single operation parseSSD and it have to have single implementation as well.

From my point of view need to redesign input parameters.

@mpashchenkov mpashchenkov force-pushed the mp/ocv-gapi-parsessd-fix branch from a00599e to 893ae82 Compare April 2, 2021 13:01
@asenyaev
Copy link
Copy Markdown
Contributor

asenyaev commented Apr 8, 2021

jenkins cn please retry a build

@mpashchenkov mpashchenkov force-pushed the mp/ocv-gapi-parsessd-fix branch from fc68359 to b280d29 Compare June 3, 2021 10:11
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Jun 7, 2021

@mpashchenkov is this PR still actual or you have another solution now? Where did that clean-up happen? Should we close this one?

@mpashchenkov
Copy link
Copy Markdown
Contributor Author

@dmatveev, this PR contains the last decision we made. It is actual.

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@alalek Can it be merged ?

@alalek alalek merged commit 651967b into opencv:master Jun 15, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
…d-fix

G-API: Removing ParseSSD overload.

* Removed specialization.

* Removed united
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants