[G-API]: Performance tests for fitLine and findContours#19337
Merged
alalek merged 4 commits intoopencv:masterfrom Jan 24, 2021
Merged
[G-API]: Performance tests for fitLine and findContours#19337alalek merged 4 commits intoopencv:masterfrom
alalek merged 4 commits intoopencv:masterfrom
Conversation
Contributor
Author
|
@aDanPin please take a look |
Contributor
|
@anna-khakimova, just in case. |
fec354e to
8830446
Compare
mpashchenkov
approved these changes
Jan 22, 2021
Contributor
mpashchenkov
left a comment
There was a problem hiding this comment.
Looks good for me. Thanks.
aDanPin
approved these changes
Jan 22, 2021
| static void findContoursTestOpenCVCompare(const cv::Mat& in, const cv::RetrievalModes mode, | ||
| const cv::ContourApproximationModes method, | ||
| const std::vector<std::vector<cv::Point>>& out_cnts_gapi, | ||
| const std::vector<cv::Vec4i>& out_hier_gapi, |
Contributor
There was a problem hiding this comment.
Sometimes you align some code timing sometimes you don't
It seems to me that it is better to either equalize everything or nothing
aDanPin
approved these changes
Jan 22, 2021
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
[G-API]: Performance tests for fitLine and findContours * Perf.Test for findContours(H) * Perf.Test for fitLine(2D.3D;Mat,vector<Point2i/2f/2d/3i/3f/3d>) * Reducing the template specializations number * Applying comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fitLineandfindContoursoperations addedPull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.