Skip to content

videoio(plugins): split capture and writer APIs#19320

Merged
alalek merged 5 commits intoopencv:masterfrom
alalek:videoio_plugins_api_split_capture_write
Jan 18, 2021
Merged

videoio(plugins): split capture and writer APIs#19320
alalek merged 5 commits intoopencv:masterfrom
alalek:videoio_plugins_api_split_capture_write

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jan 13, 2021

relates #19027

  • separate APIs versioning
  • module keeps support of both versions

Review the last commit only. Others are technical commits to keep git history properly:

force_builders=Custom
buildworker:Custom=linux-1,linux-2,linux-4
Xbuild_image:Custom=ubuntu:20.04
build_image:Custom=ubuntu-openvino-2021.2.0:20.04
test_modules:Custom=videoio

build_image:Linux OpenCL=ubuntu:20.04
ci_branch:Linux OpenCL=no-checks

Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand cap_mfx and cap_msmf still use legacy API scheme. Can we remove support of "combined API" after transitioning both backends to the new scheme?

return;
}
}
if (pluginBackend->plugin_api_)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could show a warning about old API deprecation.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFmpeg wrapper on Windows still uses old Plugin API.

@alalek alalek merged commit 5e5f473 into opencv:master Jan 18, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants