videoio: plugins API versioning#19027
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Dec 24, 2020
Merged
Conversation
alalek
commented
Dec 6, 2020
Member
Author
alalek
left a comment
There was a problem hiding this comment.
It make sense to split on 2 interfaces for VideoCapture and VideoWriter
| CV_Assert(plugin_api); | ||
| CvPluginWriter writer = NULL; | ||
| if (plugin_api->api_header.api_version >= 1 && plugin_api->Writer_open_with_params) | ||
| if (plugin_api->api_header.api_version >= 1 && plugin_api->v1.Writer_open_with_params) |
Member
Author
There was a problem hiding this comment.
v0 access doesn't require api_version checks
v1+ access requires api_version check and compatibility warnings about missing features CV_LOG_WARNING(... due to lower API level)
Comment on lines
+1842
to
1844
| #define ABI_VERSION 0 | ||
| #define API_VERSION 1 | ||
| #include "plugin_api.hpp" |
Member
Author
There was a problem hiding this comment.
ABI_VERSION / API_VERSION must be defined on plugins size (defined(BUILD_PLUGIN)) before including plugin_api.hpp
mshabunin
approved these changes
Dec 6, 2020
6 tasks
Contributor
|
Looks like we forgot to add ABI/API macros to the mfx plugin #define ABI_VERSION 0
#define API_VERSION 0 |
Member
Author
|
Please check fix here: #19321 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised support for plugin API versioning.
RFC
/cc @mshabunin @asmorkalov @joshdoe
Thanks for looking at these and providing feedback.
To be merged after the current release.