[G-API] Python ROI generic inference by TolyaTalamanov · Pull Request #19318 · opencv/opencv

TolyaTalamanov · 2021-01-13T11:18:57Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Build configuration

Xforce_builders_only=linux,docs
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.1.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

TolyaTalamanov · 2021-01-18T12:39:20Z

@dmatveev @smirnov-alexey Could you take a look ?

smirnov-alexey · 2021-01-19T15:56:04Z

@TolyaTalamanov seems like it comes atop of a bunch of other PRs. Can't you separate the changes here?

modules/python/src2/cv2.cpp

TolyaTalamanov · 2021-03-19T13:41:45Z

@smirnov-alexey Could you have a look, please ?

TolyaTalamanov · 2021-03-19T13:49:40Z

@AsyaPronina @smirnov-alexey Could you have a look, please ?

smirnov-alexey · 2021-03-22T16:23:53Z

modules/gapi/misc/python/test/test_gapi_infer.py

+
+
+    def make_roi(self, img, roi):
+        return img[roi[1]:roi[1] + roi[3], roi[0]:roi[0] + roi[2], ...]


How does this work?

roi - is a tuple (x,y,h,w)

(x,y,h,w)

Probably it is (x,y,w,h)

Clear code (to avoid unclear error messages):

x, y, w, h = roi return img[y:y+h, x:x+w, ...]

smirnov-alexey · 2021-03-22T16:25:59Z

modules/gapi/misc/python/test/test_gapi_infer.py

+        if not cv.dnn.DNN_TARGET_CPU in cv.dnn.getAvailableTargets(cv.dnn.DNN_BACKEND_INFERENCE_ENGINE):
+            return
+
+        root_path    = '/omz_intel_models/intel/age-gender-recognition-retail-0013/FP32/age-gender-recognition-retail-0013'


Don't we have some policy regarding our tests, that if we don't find models/data, we don't run the tests? Won't those tests start failing later with new paths?

I believe we don't care about it in these tests.

smirnov-alexey · 2021-03-22T16:26:43Z

modules/gapi/misc/python/pyopencv_gapi.hpp

                    reinterpret_cast<pyopencv_gapi_wip_IStreamSource_t*>(item)->v;
                return source;
            }
-            else


I would keep the else here, but it's up to you

TolyaTalamanov · 2021-03-22T17:17:24Z

@TolyaTalamanov seems like it comes atop of a bunch of other PRs. Can't you separate the changes here?

This bunch of PRs already in master, there is only actual separate changes

modules/gapi/include/opencv2/gapi/infer.hpp

dmatveev · 2021-03-24T12:16:11Z

modules/gapi/misc/python/shadow_gapi.hpp

+   public:
+       GAPI_WRAP GInferListInputs();
+       GAPI_WRAP void setInput(const std::string& name, const cv::GArray<cv::GMat>& value);
+       GAPI_WRAP void setInput(const std::string& name, const cv::GArray<cv::Rect>& value);


where's the implementation?

I only see .hpp files in this MR

There is no implementation, this file isn't compiled at all.

It's just a trigger for bindings generator

But why do we need it then? How it works? Can you please comment it in the code so then strangers like me wouldn't ask those questions again and again?

dmatveev

Please put the comment to the python wrapper thing somewhere later.

TolyaTalamanov · 2021-03-25T11:32:14Z

@alalek Can it be merged ?

alalek · 2021-03-25T16:36:30Z

modules/gapi/misc/python/test/test_gapi_infer.py

+        if not cv.dnn.DNN_TARGET_CPU in cv.dnn.getAvailableTargets(cv.dnn.DNN_BACKEND_INFERENCE_ENGINE):
+            return
+
+        root_path    = '/omz_intel_models/intel/age-gender-recognition-retail-0013/FP32/age-gender-recognition-retail-0013'


Remove leading slash /

alalek · 2021-03-25T16:48:06Z

modules/gapi/misc/python/test/test_gapi_infer.py

+
+
+    def make_roi(self, img, roi):
+        return img[roi[1]:roi[1] + roi[3], roi[0]:roi[0] + roi[2], ...]


(x,y,h,w)

Probably it is (x,y,w,h)

Clear code (to avoid unclear error messages):

x, y, w, h = roi return img[y:y+h, x:x+w, ...]

alalek · 2021-03-25T16:54:35Z

modules/gapi/misc/python/test/test_gapi_core.py

          ('fluid'  , cv.gapi.core.fluid.kernels())
          # ('plaidml', cv.gapi.core.plaidml.kernels())
-      ]
+       ]


Perhaps whole block should be reformatted

…-infer [G-API] Python ROI generic inference * Python generic infer overloads * Move wrappers to appropriate file

TolyaTalamanov added category: python bindings category: g-api / gapi labels Jan 13, 2021

TolyaTalamanov requested a review from dmatveev January 18, 2021 12:38

alalek reviewed Mar 11, 2021

View reviewed changes

modules/python/src2/cv2.cpp Show resolved Hide resolved

TolyaTalamanov force-pushed the at/python-generic-infer branch from bed239e to a5031b9 Compare March 12, 2021 09:17

TolyaTalamanov force-pushed the at/python-generic-infer branch 3 times, most recently from 86e057f to 48bb099 Compare March 19, 2021 13:37

Python generic infer overloads

244eea6

TolyaTalamanov force-pushed the at/python-generic-infer branch from 48bb099 to 244eea6 Compare March 19, 2021 13:40

TolyaTalamanov requested review from AsyaPronina and smirnov-alexey March 19, 2021 13:49

smirnov-alexey reviewed Mar 22, 2021

View reviewed changes

smirnov-alexey approved these changes Mar 22, 2021

View reviewed changes

dmatveev reviewed Mar 24, 2021

View reviewed changes

Move wrappers to appropriate file

7e25e1d

dmatveev self-assigned this Mar 25, 2021

dmatveev approved these changes Mar 25, 2021

View reviewed changes

alalek reviewed Mar 25, 2021

View reviewed changes

alalek merged commit 0753408 into opencv:master Mar 25, 2021

alalek mentioned this pull request Apr 9, 2021

(5.x) Merge 4.x #19885

Merged

a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023

Merge pull request opencv#19318 from TolyaTalamanov:at/python-generic…

5a534eb

…-infer [G-API] Python ROI generic inference * Python generic infer overloads * Move wrappers to appropriate file



		def make_roi(self, img, roi):
		return img[roi[1]:roi[1] + roi[3], roi[0]:roi[0] + roi[2], ...]

Uh oh!

Conversation

TolyaTalamanov commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Build configuration

Uh oh!

TolyaTalamanov commented Jan 18, 2021

Uh oh!

smirnov-alexey commented Jan 19, 2021

Uh oh!

Uh oh!

TolyaTalamanov commented Mar 19, 2021

Uh oh!

TolyaTalamanov commented Mar 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Mar 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Mar 25, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TolyaTalamanov commented Jan 13, 2021 •

edited

Loading

TolyaTalamanov commented Mar 22, 2021 •

edited

Loading