Remove blurb about patent in python SIFT example#19258
Merged
alalek merged 2 commits intoopencv:3.4from Jan 5, 2021
Merged
Conversation
alalek
reviewed
Jan 5, 2021
| paper is highly recommended. Remember one thing, this algorithm is patented. So this algorithm is | ||
| included in [the opencv contrib repo](https://github.com/opencv/opencv_contrib) | ||
| This is a summary of SIFT algorithm. For more details and understanding, reading the original | ||
| paper is highly recommended. |
Member
There was a problem hiding this comment.
I would suggest to keep a note about the patent expiration. Something like these.
-Remember one thing, this algorithm is patented.
+The patent on SIFT expired in 2020
Contributor
Author
There was a problem hiding this comment.
Sure, I added the note to the "SIFT in OpenCV" section, instead. It seemed a little out of context in the step-by-step algorithm summary section.
Member
|
This patch should go into 3.4 branch first. Please:
Note: no needs to re-open PR, apply changes "inplace". |
d83a97b to
6a39053
Compare
alalek
approved these changes
Jan 5, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Thank you for contribution 👍
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor fix to the python SIFT example in the documentation. It removes a couple of sentences related to the patent and the part that points to the contrib repo since those those no longer seem applicable.
relates #19258