[G-API]: Performance tests for boundingRect#19215
Merged
alalek merged 6 commits intoopencv:masterfrom Jan 12, 2021
Merged
Conversation
Contributor
Author
|
@rgarnov please, review |
rgarnov
requested changes
Dec 25, 2020
Contributor
rgarnov
left a comment
There was a problem hiding this comment.
Just a small improvement proposal from me
… default constructor for CompareF
| { | ||
| cv::Rect out_rect_gapi; | ||
| boundingRectTestGAPI(in, std::move(args), out_rect_gapi); | ||
|
|
Contributor
There was a problem hiding this comment.
I think, empty space can be removed.
mpashchenkov
approved these changes
Dec 31, 2020
Contributor
mpashchenkov
left a comment
There was a problem hiding this comment.
Overall looks good. Thanks.
rgarnov
approved these changes
Jan 11, 2021
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
[G-API]: Performance tests for boundingRect * Update boundingRect() tests with the changes from fitLine() PR * Add performance tests for boundingRect * Applying comment about g_type_of_t * Addressing comments * Addressing comment: replace cmp_f by CompareF in perf.tests + add the default constructor for CompareF * Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boundingRectoperation addedPull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.