Skip to content

[G-API] Fix streaming kernels in standalone #19205

Merged
alalek merged 2 commits intoopencv:masterfrom
TolyaTalamanov:at/remove-streamingbackend-export
Dec 24, 2020
Merged

[G-API] Fix streaming kernels in standalone #19205
alalek merged 2 commits intoopencv:masterfrom
TolyaTalamanov:at/remove-streamingbackend-export

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Dec 23, 2020

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
Xforce_builders_only=linux,docs
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Dec 23, 2020

@dbudniko Could you have a look ?

@TolyaTalamanov TolyaTalamanov force-pushed the at/remove-streamingbackend-export branch 2 times, most recently from a6f510b to 0b5aa95 Compare December 23, 2020 13:00
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Dec 23, 2020

@rgarnov Could you take a look, please ?

rgarnov
rgarnov requested changes Dec 23, 2020
View reviewed changes
@TolyaTalamanov TolyaTalamanov force-pushed the at/remove-streamingbackend-export branch from 0b5aa95 to 51b8f15 Compare December 23, 2020 13:55
TolyaTalamanov
TolyaTalamanov commented Dec 23, 2020
View reviewed changes
modules/gapi/src/executor/gstreamingexecutor.cpp
// In the current implementation, such islands
// _must_ start with copy
GAPI_Assert(isl->in_ops().size() == 1u);
#if !defined(GAPI_STANDALONE)
Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmatveev There's no need for that anymore, is there ?

Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@TolyaTalamanov TolyaTalamanov changed the title [G-API] Remove export for streaming backend [G-API] Fix streaming kernels in standalone Dec 23, 2020
rgarnov
rgarnov requested changes Dec 23, 2020
View reviewed changes
@alalek alalek merged commit 244511e into opencv:master Dec 24, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov
Merge pull request opencv#19205 from TolyaTalamanov:at/remove-streami…
c082d7e 
…ngbackend-export

[G-API] Fix streaming kernels in standalone

* Move streaming kernels from public header

* Add streaming backend to standalone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgarnov rgarnov rgarnov approved these changes

@dmatveev dmatveev Awaiting requested review from dmatveev

@dbudniko dbudniko Awaiting requested review from dbudniko

Assignees

@rgarnov rgarnov

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@TolyaTalamanov @dmatveev @rgarnov @alalek