Skip to content

Generic copy kernel#19112

Merged
alalek merged 3 commits intoopencv:masterfrom
rgarnov:rg/generic_copy_kernel
Dec 16, 2020
Merged

Generic copy kernel#19112
alalek merged 3 commits intoopencv:masterfrom
rgarnov:rg/generic_copy_kernel

Conversation

@rgarnov
Copy link
Copy Markdown
Contributor

@rgarnov rgarnov commented Dec 14, 2020 •
edited by alalek
Loading

Summary

  • Added generic copy kernel
  • Moved RMat wrapping on the inputs to StreamInput to eliminate a difference between GIslandExecutable::run() overloads (the streaming one didn't have computation inputs wrapped)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f
test_modules:Custom=gapi,python2

@dmatveev dmatveev added this to the 4.5.1 milestone Dec 15, 2020
@dmatveev dmatveev self-assigned this Dec 15, 2020
dmatveev
dmatveev reviewed Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an existing cv::gapi::copy kernel in at least OCV and OCL backends (maybe in Fluid, too) which makes plain old copy.

That kernel must be removed (with its API).

@rgarnov
Copy link
Copy Markdown
Contributor Author

rgarnov commented Dec 15, 2020

@dmatveev updated

smirnov-alexey
smirnov-alexey reviewed Dec 15, 2020
View reviewed changes
smirnov-alexey
smirnov-alexey reviewed Dec 15, 2020
View reviewed changes
smirnov-alexey
smirnov-alexey approved these changes Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smirnov-alexey smirnov-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I'm not sure if removing the plain copy is a good thing. Somebody might have been using it

@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Dec 15, 2020

Somebody might have been using it

It should remain as an operation.

dmatveev
dmatveev reviewed Dec 15, 2020
View reviewed changes
@rgarnov rgarnov force-pushed the rg/generic_copy_kernel branch from d68f217 to 4fe42b0 Compare December 15, 2020 18:58
@rgarnov
Copy link
Copy Markdown
Contributor Author

rgarnov commented Dec 15, 2020

@dmatveev updated

@rgarnov rgarnov force-pushed the rg/generic_copy_kernel branch from 4fe42b0 to 9cdd602 Compare December 15, 2020 19:05
dmatveev
dmatveev approved these changes Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 15, 2020

@rgarnov Please avoid test_gapi failure on Custom builder. Need to add try-catch-skip code - there are several PRs with examples how to do that.

@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Dec 16, 2020

@alalek btw so far this is the last thing we might need for 4.5.1 (to make it as a basis for further internal releases)

@rgarnov rgarnov force-pushed the rg/generic_copy_kernel branch from 9cdd602 to 738dc58 Compare December 16, 2020 09:48
@alalek alalek merged commit f7cab12 into opencv:master Dec 16, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#19112 from rgarnov:rg/generic_copy_kernel
11b1e21 
Generic copy kernel

* Moved RMat wrapping of cv::Mats to StreamingInput

* Generalized GCopy kernel

* Generic GCopy kernel: applied review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smirnov-alexey smirnov-alexey smirnov-alexey approved these changes

@dmatveev dmatveev dmatveev approved these changes

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@rgarnov @dmatveev @alalek @smirnov-alexey