Skip to content

[G-API]: Performance tests for color conversion kernels#19103

Merged
alalek merged 2 commits intoopencv:masterfrom
OrestChura:oc/cvtI420_perftests
Dec 14, 2020
Merged

[G-API]: Performance tests for color conversion kernels#19103
alalek merged 2 commits intoopencv:masterfrom
OrestChura:oc/cvtI420_perftests

Conversation

@OrestChura
Copy link
Copy Markdown
Contributor

@OrestChura OrestChura commented Dec 14, 2020

Performance tests for 5 new color conversion kernels:

  • BGR2RGB
  • BGR2I420
  • RGB2I420
  • I4202BGR
  • I4202RGB

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

xbuild_image:Custom=ubuntu-openvino-2021.1.0:20.04
xbuild_image:Custom Win=openvino-2021.1.0
xbuild_image:Custom Mac=openvino-2021.1.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@OrestChura
Performance tests for 5 new color conversion kernels:
231da15 
 - BGR2RGB
 - BGR2I420
 - RGB2I420
 - I4202BGR
 - I4202RGB
@OrestChura
Copy link
Copy Markdown
Contributor Author

OrestChura commented Dec 14, 2020

@AsyaPronina @mpashchenkov please review

mpashchenkov
mpashchenkov reviewed Dec 14, 2020
View reviewed changes
modules/gapi/perf/common/gapi_imgproc_perf_tests_inl.hpp Outdated
}

SANITY_CHECK_NOTHING();

Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov Dec 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that majority of tests has this empty line, but for what? I think it is useless.

Copy link
Copy Markdown
Contributor Author

@OrestChura OrestChura Dec 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, removed

@alalek alalek merged commit fcdd69f into opencv:master Dec 14, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@OrestChura
Merge pull request opencv#19103 from OrestChura:oc/cvtI420_perftests
4422b7f 
[G-API]: Performance tests for color conversion kernels

* Performance tests for 5 new color conversion kernels:
 - BGR2RGB
 - BGR2I420
 - RGB2I420
 - I4202BGR
 - I4202RGB

* Addressing comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AsyaPronina AsyaPronina AsyaPronina approved these changes

@mpashchenkov mpashchenkov Awaiting requested review from mpashchenkov

Assignees

@AsyaPronina AsyaPronina

Labels

category: g-api / gapi test

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@OrestChura @AsyaPronina @mpashchenkov @alalek