Make xcframework output path argument explicit and required#19088
Merged
alalek merged 3 commits intoopencv:masterfrom Dec 12, 2020
Merged
Conversation
6 tasks
Contributor
Author
|
When we can make breaking changes, we should do the same for the ios/osx |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…amework-output-path-explicit Make xcframework output path argument explicit and required * Make output path argument explicit and required * Improve xcframework documentation * Add TODOs for future breaking changes on build_framework.py scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR forces users to supply an output path with an explicit argument when using
build_xcframework.py.python3 build_xcframework.py outputpathpython3 build_xcframework.py --out outputpathThis reduces the possibility for argument parsing to go wrong, as in #19086 which prompted this PR. To reduce the likelihood of similar issues in the future, I've also improved the documentation here.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.