Fix path resolution bugs for XCFramework builds#19076
Merged
alalek merged 2 commits intoopencv:masterfrom Dec 11, 2020
Merged
Conversation
4 tasks
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…h-resolution-bugs Fix path resolution bugs for XCFramework builds * Fix incorrect paths for intermediate frameworks * Remove unnecessary `./` prepend preventing use of absolute paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug found by @vade here, wherein the
xcodebuildcommand to build the xcframework was being given the wrong paths to the constituent frameworks. It was introduced in 69e1167.I also found another issue that prevents the use of absolute paths when assembling the xcframework, so I've also included a fix for that.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.