cmake: fix handling of wrappers dependencies#19059
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Dec 9, 2020
Merged
Conversation
6 tasks
mshabunin
reviewed
Dec 9, 2020
| endif() | ||
|
|
||
| # add reverse wrapper dependencies (BINDINDS) | ||
| foreach(the_module ${OPENCV_MODULES_BUILD}) |
Contributor
There was a problem hiding this comment.
Is it possible that OPENCV_MODULES_BUILD would change in the next block (lines 508-524) due to missing dependencies?
Member
Author
There was a problem hiding this comment.
These dependencies are specified as "OPTIONAL", so this case should be handled.
mshabunin
approved these changes
Dec 9, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates #19000
OPENCV_MODULE_opencv_${wrapper}_bindings_generator_CLASSmay be not available during ongoing first pass modules scan.Wrappers handling is moved to pre-processing part of
__ocv_resolve_dependencies().